Page MenuHomePhabricator
Create Task
Maniphest T103077

First heading is missing when page title is "0"
Closed, ResolvedPublic
Actions

Description

In

https://en.wikipedia.org/wiki/0
https://meta.wikimedia.org/wiki/0
https://test.wikipedia.org/wiki/0

the element '<h1 id="firstHeading" class="firstHeading" lang="en">' with its content (page title) is missing where it's supposed to be.

Details

SubjectRepoBranchLines /-
Don't output an empty h1 element (once more, with feeling)mediawiki/skins/MonoBookmaster 2 -1
Don't output an empty h1 element (once more, with feeling)mediawiki/skins/Vectormaster 2 -1
Display the page title on pages named '0'mediawiki/skins/MonoBookmaster 1 -1
Display the page title on pages named '0'mediawiki/skins/Vectormaster 1 -1
Customize query in gerrit

Related Objects

Event Timeline

whym created this task.Jun 19 2015, 10:57 AM
whym raised the priority of this task from to Needs Triage.
whym updated the task description. (Show Details)
whym added a project: MediaWiki-General.
whym subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 19 2015, 10:57 AM
Aklapper triaged this task as Low priority.Jun 24 2015, 1:51 PM
Ciencia_Al_Poder added a project: Technical-Debt.Jun 24 2015, 1:56 PM
Ciencia_Al_Poder subscribed.

This looks like somewhere in code we're checking if Title is false, which in PHP an empty string, 0 or the string "0" are also considered false :S

polybuildr subscribed.Jun 24 2015, 1:59 PM
polybuildr added a project: Vector (legacy skin).Jun 24 2015, 2:19 PM

So I looked around to see where this is happening, and it's not a core issue, it's a skin issue. You can confirm this by visiting https://www.mediawiki.org/wiki/0 and https://www.mediawiki.org/wiki/0?useskin=cologneblue.

Ciencia_Al_Poder added a project: MonoBook.Jun 24 2015, 2:26 PM

Adding monobook as well, then :)

Ciencia_Al_Poder edited projects, added good first task; removed MediaWiki-General.Jun 24 2015, 4:50 PM
Ciencia_Al_Poder set Security to None.
Legoktm claimed this task.Jun 24 2015, 5:11 PM
gerritbot subscribed.Jun 24 2015, 5:14 PM

Change 220501 had a related patch set uploaded (by Legoktm):
Display the page title on pages named '0'

https://gerrit.wikimedia.org/r/220501

gerritbot added a project: Patch-For-Review.Jun 24 2015, 5:14 PM

Change 220502 had a related patch set uploaded (by Legoktm):
Display the page title on pages named '0'

https://gerrit.wikimedia.org/r/220502

gerritbot added a comment.Jun 24 2015, 5:28 PM

Change 220502 merged by jenkins-bot:
Display the page title on pages named '0'

https://gerrit.wikimedia.org/r/220502

gerritbot added a comment.Jun 24 2015, 5:28 PM

Change 220501 merged by jenkins-bot:
Display the page title on pages named '0'

https://gerrit.wikimedia.org/r/220501

Legoktm mentioned this in rSKIN27f958f1cec8: Updated mediawiki/skins Project: mediawiki/skins/Vector….Jun 24 2015, 5:28 PM
Legoktm mentioned this in rSKIN9b8de1d1476a: Updated mediawiki/skins Project: mediawiki/skins/MonoBook….
Legoktm closed this task as Resolved.Jun 24 2015, 5:29 PM
Legoktm mentioned this in rSVECa85145a5c895: Display the page title on pages named '0'.Jun 24 2015, 5:29 PM
Legoktm mentioned this in rSMNBf2846c51df81: Display the page title on pages named '0'.
• Forrestbot added a project: WMF-deploy-2015-06-30_(1.26wmf12).Jun 24 2015, 6:00 PM
• Forrestbot subscribed.
matmarex added subscribers: matmarex, Jdlrobson, Florian.Jun 25 2015, 11:30 AM

This regresses T97891. The code shouldn't display the title for zero-length strings.

polybuildr added a comment.Jun 25 2015, 11:33 AM

if ( isset( $this->data['title'] ) && strlen( trim( $this->data['title'] ) ) ) would maybe work better then?

gerritbot added a comment.Jun 25 2015, 11:52 AM

Change 220745 had a related patch set uploaded (by Bartosz Dziewoński):
Don't output an empty h1 element (one more, with feeling)

https://gerrit.wikimedia.org/r/220745

gerritbot added a comment.Jun 25 2015, 11:52 AM

Change 220746 had a related patch set uploaded (by Bartosz Dziewoński):
Don't output an empty h1 element (one more, with feeling)

https://gerrit.wikimedia.org/r/220746

matmarex reopened this task as Open.Jun 25 2015, 11:53 AM
gerritbot added a comment.Jun 25 2015, 5:07 PM

Change 220746 merged by jenkins-bot:
Don't output an empty h1 element (once more, with feeling)

https://gerrit.wikimedia.org/r/220746

matmarex mentioned this in rSKIN224c2d5df8ce: Updated mediawiki/skins Project: mediawiki/skins/Vector….Jun 25 2015, 5:07 PM
matmarex mentioned this in rSVEC51278f2d1019: Don't output an empty h1 element (once more, with feeling).
gerritbot added a comment.Jun 25 2015, 6:13 PM

Change 220745 merged by jenkins-bot:
Don't output an empty h1 element (once more, with feeling)

https://gerrit.wikimedia.org/r/220745

matmarex mentioned this in rSKIN1dc1a8281a10: Updated mediawiki/skins Project: mediawiki/skins/MonoBook….Jun 25 2015, 6:14 PM
matmarex mentioned this in rSMNB767349cbb42c: Don't output an empty h1 element (once more, with feeling).
matmarex closed this task as Resolved.Jun 26 2015, 1:00 PM
Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM
Legoktm mentioned this in rSVEVa85145a5c895: Display the page title on pages named '0'.Mar 8 2016, 3:29 PM
matmarex mentioned this in rSVEV51278f2d1019: Don't output an empty h1 element (once more, with feeling).Mar 8 2016, 3:29 PM
Pipetricker mentioned this in T219864: Articles about zero (0) not displaying title in Vector skin.Apr 3 2019, 12:32 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits