Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settings: Make the empty panel text darker in light theme. #32441

Merged
merged 1 commit into from
Nov 26, 2024
Merged

settings: Make the empty panel text darker in light theme. #32441

merged 1 commit into from
Nov 26, 2024

Conversation

sahil839
Copy link
Collaborator

Text shown for empty left and right panels in stream and group settings UI was too faded in light theme, so we make the text a little darker.

Fixes #32212.

Screenshots and screen captures:

Screenshot from 2024-11-23 17-19-18
Screenshot from 2024-11-23 17-18-56

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@zulipbot
Copy link
Member

Hello @zulip/server-settings members, this pull request was labeled with the "area: settings UI" label, so you may want to check it out!

@timabbott
Copy link
Member

Is there a color variable for this color that we should use?

@sahil839
settings: Make the empty panel text darker in light theme.
b8ed559 
Text shown for empty left and right panels in stream and group
settings UI was too faded in light theme, so we make the text
a little darker.

Fixes zulip#32212.
@sahil839
Copy link
Collaborator Author

Updated the PR to use --color-text-item variable which is set to hsl(0, 0%, 40%) in light theme and hsl(0, 0%, 50%) in dark theme.

Screenshot from 2024-11-26 12-31-19
Screenshot from 2024-11-26 12-30-11

@timabbott timabbott merged commit ba48e01 into zulip:main Nov 26, 2024
7 checks passed
@timabbott
Copy link
Member

Yeah that seems like a great answer, merged, thanks @sahil839!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: settings UI area: settings (user groups) User groups related settings issues size: XS
Projects
Groups migration and new settings
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve "Create group" / "Create channel" UI
3 participants
@sahil839 @zulipbot @timabbott