-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding: Improve placeholder message for dm with yourself #29079
Conversation
Hello @zulip/server-onboarding members, this pull request was labeled with the "area: onboarding" label, so you may want to check it out! |
7fd867d
to
640cb56
Compare
640cb56
to
419157b
Compare
Let's add the link to wrap "Use this space" or the entire sentence in the second line |
@nimishmedatwal the issue was updated with a revised string, can you update this? Otherwise lgtm. |
@timabbott Updated! |
@timabbott your views on this? |
Hm, I didn't think about this question carefully when writing up the issue, but I actually don't see much benefit in the link. Most ways that you can navigate to DMs with yourself will result in the compose box already being open when you get there. In that case, it can actually feel confusing to have a link, because nothing will happen if you click it. I'm actually wondering now if we should remove the link from the other DM placeholders. |
Marking for integration review, @timabbott FYI. |
CZO thread for the more general discussion about these links. |
Merged, thanks @nimishmedatwal! |
This pr changes placeholder text for dm with yourself from
Why not start a conversation with yourself
toUse this space for personal notes and test messages.
Fixes: #29078
Screenshots and screen captures:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: