Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding: Improve placeholder message for dm with yourself #29079

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

nimishmedatwal
Copy link
Collaborator

@nimishmedatwal nimishmedatwal commented Feb 27, 2024

This pr changes placeholder text for dm with yourself from Why not start a conversation with yourself to Use this space for personal notes and test messages.

Fixes: #29078

Screenshots and screen captures:
image

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@zulipbot
Copy link
Member

Hello @zulip/server-onboarding members, this pull request was labeled with the "area: onboarding" label, so you may want to check it out!

@beenotung
Copy link

Let's add the link to wrap "Use this space" or the entire sentence in the second line

@timabbott
Copy link
Member

@nimishmedatwal the issue was updated with a revised string, can you update this? Otherwise lgtm.

@nimishmedatwal
Copy link
Collaborator Author

@timabbott Updated!

@CodeWithOlaf
Copy link
Collaborator

Shouldn't the text be wrapped in a link ?
Because the link causes the person to be added in DM list provided below, I guess by having plain text we are missing on that functionality
This is what i am talking about

@nimishmedatwal
Copy link
Collaborator Author

Shouldn't the text be wrapped in a link ? Because the link causes the person to be added in DM list provided below, I guess by having plain text we are missing on that functionality This is what i am talking about

@timabbott your views on this?

@alya
Copy link
Contributor

alya commented Mar 1, 2024

Hm, I didn't think about this question carefully when writing up the issue, but I actually don't see much benefit in the link. Most ways that you can navigate to DMs with yourself will result in the compose box already being open when you get there. In that case, it can actually feel confusing to have a link, because nothing will happen if you click it.

I'm actually wondering now if we should remove the link from the other DM placeholders.

@alya
Copy link
Contributor

alya commented Mar 1, 2024

Marking for integration review, @timabbott FYI.

@alya alya added the integration review Added by maintainers when a PR may be ready for integration. label Mar 1, 2024
@alya
Copy link
Contributor

alya commented Mar 1, 2024

CZO thread for the more general discussion about these links.

@timabbott timabbott merged commit 3d30fcd into zulip:main Mar 2, 2024
8 checks passed
@timabbott
Copy link
Member

Merged, thanks @nimishmedatwal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: onboarding integration review Added by maintainers when a PR may be ready for integration. priority: high size: S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve placeholder message in DMs with yourself
7 participants