Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve "Create group" / "Create channel" UI #32212

Closed
alya opened this issue Nov 1, 2024 · 1 comment · Fixed by #32441
Closed

Improve "Create group" / "Create channel" UI #32212

alya opened this issue Nov 1, 2024 · 1 comment · Fixed by #32441
Assignees
@sahil839
Labels
area: settings UI area: settings (user groups) User groups related settings issues in progress

Comments

@alya
Copy link
Contributor

alya commented Nov 1, 2024 •
edited
Loading

In the "Create group" / "Create channel" UI, we should:

  1. Move the explanation of groups and channels to a blue banner at the top of the right-side panel, reserving the space below the button for notes about permissions. Let's also improve the content while we're at it, making it consistent with the help center:

Channels organize conversations based on who needs to see them. Learn more <- "Learn more" is a button, if that's not a pain with our current banners.
User groups offer a flexible way to manage permissions in your organization. Learn more <- "Learn more" is a button

These banners should be shown regardless of whether the user has permission to create a channel/group.

  1. Make the text below the button not look so faded in light theme. Same for the text in the left-side panel when there are not groups or channels to show.
    Screenshot 2024-11-01 at 16 02 01
    Screenshot 2024-11-01 at 15 58 14

Dark theme seems OK.

  1. When the user doesn't have permission to create groups, show a disabled "Create user group" button, just like we do with "Create channel". Text below the button:

You do not have permission to create user groups.

For channels, the text should be updated to:

You do not have permission to create channels.
@alya alya added area: settings UI area: settings (user groups) User groups related settings issues labels Nov 1, 2024
@zulipbot
Copy link
Member

zulipbot commented Nov 1, 2024

Hello @zulip/server-settings members, this issue was labeled with the "area: settings UI" label, so you may want to check it out!

@sahil839 sahil839 self-assigned this Nov 2, 2024
sahil839 added a commit to sahil839/zulip that referenced this issue Nov 2, 2024
@sahil839
group-settings: Update right pannel for user without creation permiss…
e2a60e1 
…ion.

This commit updates the right panel for groups to be same as we
have it for stream settings when the user does not have permission
to create groups.

Fixes part of zulip#32212.
sahil839 added a commit to sahil839/zulip that referenced this issue Nov 2, 2024
@sahil839
settings: Show stream and group info in a banner at the top.
95da7c1 
Instead of having information about streams and groups below the
create button, we show that in a banner at the top irrespective
of whether user has permission to create them or not.

Fixes part of zulip#32212.
sahil839 added a commit to sahil839/zulip that referenced this issue Nov 2, 2024
@sahil839
settings: Show stream and group info in a banner at the top.
0a315e3 
Instead of having information about streams and groups below the
create button, we show that in a banner at the top irrespective
of whether user has permission to create them or not.

Fixes part of zulip#32212.
@timabbott timabbott mentioned this issue Nov 5, 2024
Merged
12 tasks
timabbott pushed a commit that referenced this issue Nov 5, 2024
@sahil839 @timabbott
group-settings: Update right pannel for user without creation permiss…
9a50fae 
…ion.

This commit updates the right panel for groups to be same as we
have it for stream settings when the user does not have permission
to create groups.

Fixes part of #32212.
timabbott pushed a commit that referenced this issue Nov 5, 2024
@sahil839 @timabbott
settings: Show stream and group info in a banner at the top.
067e5a4 
Instead of having information about streams and groups below the
create button, we show that in a banner at the top irrespective
of whether user has permission to create them or not.

Fixes part of #32212.
OmarAmeen01 pushed a commit to OmarAmeen01/zulip that referenced this issue Nov 9, 2024
@sahil839 @OmarAmeen01
group-settings: Update right pannel for user without creation permiss…
c78252b 
…ion.

This commit updates the right panel for groups to be same as we
have it for stream settings when the user does not have permission
to create groups.

Fixes part of zulip#32212.
OmarAmeen01 pushed a commit to OmarAmeen01/zulip that referenced this issue Nov 9, 2024
@sahil839 @OmarAmeen01
settings: Show stream and group info in a banner at the top.
3a34e1a 
Instead of having information about streams and groups below the
create button, we show that in a banner at the top irrespective
of whether user has permission to create them or not.

Fixes part of zulip#32212.
vivektripaathi pushed a commit to vivektripaathi/zulip that referenced this issue Nov 16, 2024
@sahil839 @vivektripaathi
group-settings: Update right pannel for user without creation permiss…
3c6c1be 
…ion.

This commit updates the right panel for groups to be same as we
have it for stream settings when the user does not have permission
to create groups.

Fixes part of zulip#32212.
vivektripaathi pushed a commit to vivektripaathi/zulip that referenced this issue Nov 16, 2024
@sahil839 @vivektripaathi
settings: Show stream and group info in a banner at the top.
ea00132 
Instead of having information about streams and groups below the
create button, we show that in a banner at the top irrespective
of whether user has permission to create them or not.

Fixes part of zulip#32212.
sahil839 added a commit to sahil839/zulip that referenced this issue Nov 23, 2024
@sahil839
settings: Make the empty panel text darker in light theme.
7095ab1 
Text shown for empty left and right panels in stream and group
settings UI was too faded in light theme, so we make the text
a little darker.

Fixes zulip#32212.
@sahil839 sahil839 mentioned this issue Nov 23, 2024
Merged
12 tasks
sahil839 added a commit to sahil839/zulip that referenced this issue Nov 26, 2024
@sahil839
settings: Make the empty panel text darker in light theme.
b8ed559 
Text shown for empty left and right panels in stream and group
settings UI was too faded in light theme, so we make the text
a little darker.

Fixes zulip#32212.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sahil839 sahil839

Labels
area: settings UI area: settings (user groups) User groups related settings issues in progress
Projects
Groups migration and new settings
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

settings: Make the empty panel text darker in light theme. sahil839/zulip
3 participants
@alya @zulipbot @sahil839