Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup/refactor - Validators and function signatures #604

Open
zFernand0 opened this issue Nov 21, 2019 · 1 comment
Open

Cleanup/refactor - Validators and function signatures #604

zFernand0 opened this issue Nov 21, 2019 · 1 comment
Labels
bug Something isn't working priority-low Legit issue but cosmetic or nice-to-have severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases v4 Prospective changes for v4

Comments

@zFernand0
Copy link
Member

zFernand0 commented Nov 21, 2019 •
edited
Loading

Function signatures:

  • Allow up to 4 parameters per function throughout the codebase
    See startWorkflow as an example

Validators:

  • Eliminate unnecessary wrappers in favor of ImperativeExpect
    See packages/provisioning/src/api/ProvisioningValidator.ts
  • Same goes for the workflow validator. (and maybe others) 😕
@awharn awharn added bug Something isn't working for-review To be reviewed in an Eng & Prod Mgmt meeting labels Sep 14, 2022
@github-actions
Copy link

Thank you for creating a bug report. If you haven't already, please ensure you have provided steps to reproduce it and as much context as possible.

@zFernand0 zFernand0 added priority-medium Not functioning - next quarter if capacity permits and removed for-review To be reviewed in an Eng & Prod Mgmt meeting labels Oct 11, 2022
@zFernand0 zFernand0 changed the title Cleanup/refactor - Provision Validator Cleanup/refactor - Validators and function signatures Apr 21, 2023
@zFernand0 zFernand0 added priority-low Legit issue but cosmetic or nice-to-have severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases v3 prospective changes for v3 and removed priority-medium Not functioning - next quarter if capacity permits labels Apr 21, 2023
@zFernand0 zFernand0 added this to the Zowe V3 milestone Apr 25, 2023
@JTonda JTonda added v4 Prospective changes for v4 and removed v3 prospective changes for v3 labels Feb 14, 2024
@adam-wolfe adam-wolfe removed this from the Zowe V3 milestone Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority-low Legit issue but cosmetic or nice-to-have severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases v4 Prospective changes for v4
Projects
Zowe CLI Squad
Status: Low Priority
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JTonda @zFernand0 @awharn @adam-wolfe