Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Fix startup-sequence locations #1901

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

christian-heusel
Copy link
Contributor

In znc/znc-docker#28 the location of the init scripts was moved which broke the logic to copy all the init files once the docker submodule was updated in 5d7aa0f. Consequently only 30-build-modules.sh was available in the build docker image.
We fix this issue by also including all startup-sequence subfolders.

In znc/znc-docker#28 the location of the init
scripts was moved which broke the logic to copy all the init files once
the docker submodule was updated in
5d7aa0f. Consequently only
`30-build-modules.sh` was available in the build docker image. We fix
this issue by also including all startup-sequence subfolders.

Signed-off-by: Christian Heusel <[email protected]>
@christian-heusel
Copy link
Contributor Author

Before:

$ ls docker/*/??-*.sh                                                     
docker/full/30-build-modules.sh

After:

$ ls -1 docker/*/??-*.sh docker/*/startup-sequence/??-*.sh 
docker/full/30-build-modules.sh
docker/slim/startup-sequence/00-try-sh.sh
docker/slim/startup-sequence/01-options.sh
docker/slim/startup-sequence/20-chown.sh
docker/slim/startup-sequence/99-launch.sh

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.22%. Comparing base (82bf7fb) to head (f7d7d09).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1901       /-   ##
==========================================
- Coverage   44.27%   44.22%   -0.05%     
==========================================
  Files         122      122              
  Lines       32652    32647       -5     
  Branches       33       33              
==========================================
- Hits        14456    14438      -18     
- Misses      18171    18184       13     
  Partials       25       25              

see 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82bf7fb...f7d7d09. Read the comment docs.

@DarthGandalf DarthGandalf merged commit d4bda2a into znc:master Mar 2, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants