Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certauth doesn't work with Imapauth #1831

Open
Juliaria08 opened this issue Jun 8, 2022 · 8 comments
Open

Certauth doesn't work with Imapauth #1831

Juliaria08 opened this issue Jun 8, 2022 · 8 comments

Comments

@Juliaria08
Copy link

The problem

When you are a user on a Imapauth configured server, you can't use Certauth, even if the module is loaded, it appears like Imapauth doesn't support Certauth, but I don't know.
CCing @deepend-tildeclub as he's the owner of the server :D

@psychon
Copy link
Member

psychon commented Jun 8, 2022

The cause

These authentication modules all hook into a module call OnLoginAttempt(). certauth either directly accepts the login or says "let someone else handle this". imapauth cannot do that since it first has to talk to the IMAP server, so it always does "I will handle this (later) - don't ask anyone else."

I think this should work if certauth is loaded before imapauth, but not the other way around. However, AFAIK messing with the module order in znc does not really work well and might get lost across a restart. Also, telling people "you first have to load module X and only afterwards load Y" is not really a solution. I just wanted to mention what is going on.

@Juliaria08
Copy link
Author

Juliaria08 commented Jun 8, 2022

I think this should work if certauth is loaded before imapauth, but not the other way around. However, AFAIK messing with the module order in znc does not really work well and might get lost across a restart. Also, telling people "you first have to load module X and only afterwards load Y" is not really a solution. I just wanted to mention what is going on.

Then we wait, wrong?

@DarthGandalf
Copy link
Member

DarthGandalf commented Jun 8, 2022 via email

@DarthGandalf
Copy link
Member

DarthGandalf commented Jun 8, 2022 via email

@Juliaria08
Copy link
Author

Juliaria08 commented Jun 8, 2022

Sorry, what is this sentence supposed to mean? ср, 8 июн. 2022 г., 18:12 Julian Marcos @.***>:

I think this should work if certauth is loaded before imapauth, but not the other way around. However, AFAIK messing with the module order in znc does not really work well and might get lost across a restart. Also, telling people "you first have to load module X and only afterwards load Y" is not really a solution. I just wanted to mention what is going on.

Then we wait, wrong?

That we should wait, and that you should tell me if I were/am wrong.

@DarthGandalf
Copy link
Member

DarthGandalf commented Jun 8, 2022 via email

@Juliaria08
Copy link
Author

You can try the workaround psychon mentioned. But feel free to wait, if that is your wish... ср, 8 июн. 2022 г., 18:17 Julian Marcos @.>:

Sorry, what is this sentence supposed to mean? ср, 8 июн. 2022 г., 18:12 Julian Marcos @.
>: I think this should work if certauth is loaded before imapauth, but not the other way around. However, AFAIK messing with the module order in znc does not really work well and might get lost across a restart. Also, telling people "you first have to load module X and only afterwards load Y" is not really a solution. I just wanted to mention what is going on. Then we wait, wrong? That we should wait, and that you should tell me if I were/am wrong. — Reply to this email directly, view it on GitHub <#1831 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACPLZBKDN5EWBTR7GPKC3DVODBSJANCNFSM5YGWQKOQ . You are receiving this because you commented.Message ID: @.***>

Ok, I'll tell the admin about it 👍

@Juliaria08
Copy link
Author

The admin said me that he loaded CertAuth first, and it worked!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants