refactor: Drop deprecated space in operator""_mst

zkLayer · Nov 11, 2024 · faf2162 · faf2162
1 parent c889890
commit faf2162
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 17 deletions.
diff --git a/src/script/miniscript.cpp b/src/script/miniscript.cpp
@@ -1,14  1,17 @@
-// Copyright (c) 2019-2022 The Bitcoin Core developers
 // Copyright (c) 2019-present The Bitcoin Core developers
 // Distributed under the MIT software license, see the accompanying
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
-#include <string>
 #include <limits>
 #include <vector>
-#include <script/script.h>
-#include <script/miniscript.h>
-#include <serialize.h>
 
-#include <assert.h>
 #include <primitives/transaction.h>
 #include <script/miniscript.h>
 #include <script/script.h>
 #include <script/solver.h>
 #include <span.h>
 #include <util/check.h>
 #include <util/vector.h>
 
 namespace miniscript {
 namespace internal {

diff --git a/src/script/miniscript.h b/src/script/miniscript.h
@@ -1,25  1,29 @@
-// Copyright (c) 2019-2022 The Bitcoin Core developers
 // Copyright (c) 2019-present The Bitcoin Core developers
 // Distributed under the MIT software license, see the accompanying
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
 #ifndef BITCOIN_SCRIPT_MINISCRIPT_H
 #define BITCOIN_SCRIPT_MINISCRIPT_H
 
 #include <algorithm>
-#include <functional>
-#include <numeric>
 #include <compare>
 #include <cstdint>
 #include <cstdlib>
 #include <iterator>
 #include <memory>
 #include <optional>
-#include <string>
 #include <set>
 #include <stdexcept>
 #include <tuple>
 #include <utility>
 #include <vector>
 
-#include <assert.h>
-#include <cstdlib>
-
 #include <consensus/consensus.h>
 #include <policy/policy.h>
-#include <primitives/transaction.h>
 #include <script/interpreter.h>
 #include <script/parsing.h>
 #include <script/script.h>
 #include <serialize.h>
 #include <span.h>
 #include <util/check.h>
 #include <util/strencodings.h>
@@ -150,7  154,8 @@ class Type {
 };
 
 //! Literal operator to construct Type objects.
-inline consteval Type operator"" _mst(const char* c, size_t l) {
 inline consteval Type operator""_mst(const char* c, size_t l)
 {
     Type typ{Type::Make(0)};
 
     for (const char *p = c; p < c   l; p  ) {

diff --git a/src/test/fuzz/miniscript.cpp b/src/test/fuzz/miniscript.cpp
@@ -22,7  22,7 @@ using NodeRef = miniscript::NodeRef<CPubKey>;
 using Node = miniscript::Node<CPubKey>;
 using Type = miniscript::Type;
 using MsCtx = miniscript::MiniscriptContext;
-using miniscript::operator"" _mst;
 using miniscript::operator""_mst;
 
 //! Some pre-computed data for more efficient string roundtrips and to simulate challenges.
 struct TestData {

diff --git a/src/test/miniscript_tests.cpp b/src/test/miniscript_tests.cpp
@@ -293,7  293,7 @@ class TestSignatureChecker : public BaseSignatureChecker {
 
 using Fragment = miniscript::Fragment;
 using NodeRef = miniscript::NodeRef<CPubKey>;
-using miniscript::operator"" _mst;
 using miniscript::operator""_mst;
 using Node = miniscript::Node<CPubKey>;
 
 /** Compute all challenges (pubkeys, hashes, timelocks) that occur in a given Miniscript. */