Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Define redirect uris with env variables #644

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

lanseg
Copy link
Contributor

@lanseg lanseg commented Aug 27, 2024

We are planning to use Zitadel as an OpenID authentication provider for some of the Camptocamp services. Such a simple customization makes example server more convenient to create E2E tests. Using environment variables instead of command line arguments or config files for easier integration with Docker.

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.05%. Comparing base (0992c5f) to head (0824a3e).
Report is 89 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #644       /-   ##
==========================================
  Coverage   60.06%   62.05%    1.99%     
==========================================
  Files          80       81        1     
  Lines        6998     6217     -781     
==========================================
- Hits         4203     3858     -345     
  Misses       2498     2048     -450     
- Partials      297      311       14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muhlemmer muhlemmer enabled auto-merge (squash) September 2, 2024 09:13
@muhlemmer
Copy link
Collaborator

hey @lanseg thanks for the contribution.

If you'd like to have a small gift in return, please send us a mail to [email protected]. We will send you a form with questions about your address and shirt size.

@muhlemmer
Copy link
Collaborator

Can you please merge main into the PR branch? It seems maintainer push is disabled. Thanks.

@lanseg
Copy link
Contributor Author

lanseg commented Sep 2, 2024

Can you please merge main into the PR branch? It seems maintainer push is disabled. Thanks.

Done. Waiting for workflows

@muhlemmer muhlemmer merged commit e1633bd into zitadel:main Sep 3, 2024
4 checks passed
Copy link

github-actions bot commented Sep 3, 2024

🎉 This PR is included in version 3.29.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants