fix(typescript): Flesh out no-empty-function allow list

zillow · Sep 29, 2020 · 1d9438a · 1d9438a
1 parent 6249318
commit 1d9438a
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/packages/eslint-config-zillow-typescript/rules/recommended.js b/packages/eslint-config-zillow-typescript/rules/recommended.js
@@ -41,7  41,23 @@ module.exports = {
 
     // https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-empty-function.md
     'no-empty-function': 'off',
-    '@typescript-eslint/no-empty-function': 'error',
     '@typescript-eslint/no-empty-function': [
       'error',
       {
         allow: [
           // built-in: https://eslint.org/docs/rules/no-empty-function
           'arrowFunctions',
           'functions',
           'methods',
           // this plugin
           /*
           'private-constructors',
           'protected-constructors',
           'decoratedFunctions',
           */
         ],
       },
     ],
 
     // https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-empty-interface.md
     '@typescript-eslint/no-empty-interface': 'error',

diff --git a/packages/eslint-plugin-zillow/test/__snapshots__/eslint-plugin-zillow.test.js.snap b/packages/eslint-plugin-zillow/test/__snapshots__/eslint-plugin-zillow.test.js.snap
@@ -3238,6  3238,13 @@ Object {
         ],
         "zillow/@typescript-eslint/no-empty-function": Array [
           "error",
           Object {
             "allow": Array [
               "arrowFunctions",
               "functions",
               "methods",
             ],
           },
         ],
         "zillow/@typescript-eslint/no-empty-interface": Array [
           "error",