Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InternPool: fix more races #20593

Merged
merged 4 commits into from
Jul 15, 2024
Merged

InternPool: fix more races #20593

merged 4 commits into from
Jul 15, 2024

Conversation

jacobly0
Copy link
Member

No description provided.

This allows using atomics on packed structs in the compiler.
This allows the mutate mutex to only be locked during actual grows,
which are rare. For the lists that didn't previously have a mutex, this
change has little effect since grows are rare and there is zero
contention on a mutex that is only ever locked by one thread.  This
change allows `extra` to be mutated without racing with a grow.
@andrewrk andrewrk merged commit d404d8a into ziglang:master Jul 15, 2024
10 checks passed
@jacobly0 jacobly0 deleted the more-races branch July 15, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants