Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: rename wasi target OS to wasip1 #19581

Closed
ianprime0509 opened this issue Apr 8, 2024 · 4 comments
Closed

Proposal: rename wasi target OS to wasip1 #19581

ianprime0509 opened this issue Apr 8, 2024 · 4 comments
Labels
os-wasi proposal This issue suggests modifications. If it also has the "accepted" label then it is planned.
Milestone
0.12.0

Comments

@ianprime0509
Copy link
Sponsor Contributor

Since WASI preview 2 has been officially launched, and implementations of it are available, the term "WASI" by itself has become ambiguous. Eventually, in the future, when WASI is stabilized, the unqualified term "WASI" should refer to the stabilized version.

The name "wasip1" for preview 1 (which is what Zig currently supports) seems to be the preferred name going forward in the WASI ecosystem, see for example WebAssembly/wasi-libc#478

This proposal doesn't cover how Zig might eventually support preview 2 (which would likely involve several other factors, such as wasi-libc support and integration with the component model on which preview 2 is based). It just proposes renaming the existing wasi target OS to eliminate ambiguity and pave the way for future developments in this area.
@Vexu Vexu added proposal This issue suggests modifications. If it also has the "accepted" label then it is planned. os-wasi labels Apr 8, 2024
@Vexu Vexu added this to the 0.13.0 milestone Apr 8, 2024
jacobly0 added a commit to jacobly0/zig that referenced this issue Apr 14, 2024
@jacobly0
wasi: change os version to 0.0.0-preview.1
fa5ca66 
Closes ziglang#19581
@jacobly0 jacobly0 mentioned this issue Apr 14, 2024
Merged
@jacobly0
Copy link
Member

Does #19654 fit your needs?

@ianprime0509
Copy link
Sponsor Contributor Author

Thanks! That seems reasonable to me. One nit, though, is that I think it would make more sense to have WASI preview 1 be version 0.1.0 in that scheme, as preview 2 is labeled as 0.2.0 in the WIT IDL definitions. (Also, my understanding of the target query parsing code suggests to me that OS versions containing -, such as wasi.0.0.0-preview.1, would not be parseable, as the arch-OS-ABI triple is split on -, but I could be missing something)

@jacobly0
Copy link
Member

(Also, my understanding of the target query parsing code suggests to me that OS versions containing -, such as wasi.0.0.0-preview.1, would not be parseable, as the arch-OS-ABI triple is split on -, but I could be missing something)

Yeah I was wondering the same thing, but your suggested versioning solves that neatly.

@andrewrk
Copy link
Member

Solved in a2b834e.

-target wasm32-wasi.0.1.0 vs -target wasm32-wasi.0.2.0

@andrewrk andrewrk modified the milestones: 0.13.0, 0.12.0 Apr 18, 2024
@rektide rektide mentioned this issue Apr 22, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
os-wasi proposal This issue suggests modifications. If it also has the "accepted" label then it is planned.
Projects
None yet
Milestone
0.12.0
Development

No branches or pull requests
4 participants
@andrewrk @ianprime0509 @Vexu @jacobly0