Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: implement mouse double click event #9642

Merged
merged 9 commits into from
Mar 26, 2024

Conversation

JunkuiZhang
Copy link
Contributor

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 21, 2024
@mikayla-maki
Copy link
Contributor

mikayla-maki commented Mar 21, 2024

Seems like there's a bit of a conflict with this PR since I merged the others.

That said, I'm not sure this is the approach we want to go down. On macOS and Linux we get a simple counter of how many clicks a user has made, which can go as high as the user wants. Is there a compelling reason to use the NCBUTTONDBLCLICK mechanism, over an approach like in this PR: #9608, except using GetDoubleClickTime() instead of hard coding it?

@JunkuiZhang
Copy link
Contributor Author

Seems like there's a bit of a conflict with this PR since I merged the others.

That said, I'm not sure this is the approach we want to go down. On macOS and Linux we get a simple counter of how many clicks a user has made, which can go as high as the user wants. Is there a compelling reason to use the NCBUTTONDBLCLICK mechanism, over an approach like in this PR: #9608, except using GetDoubleClickTime() instead of hard coding it?

Oh, I didn't notice these double click changes in other playforms. If you wish, I can implement it for the Windows platform in a way similar to how other platforms handle the double-click mouse event.

@mikayla-maki
Copy link
Contributor

I think it would be best to match the other platforms and do things simply, unless there's a good reason to use the NCBUTTONDBLCLICK approach, in which case we should augment it with the behavior of the other platforms :)

@JunkuiZhang JunkuiZhang marked this pull request as draft March 21, 2024 19:13
@JunkuiZhang JunkuiZhang marked this pull request as ready for review March 22, 2024 16:44
@JunkuiZhang
Copy link
Contributor Author

Cargo clippy complains "recursion limit reached while expanding #[test]", should I move the tests to another file?

@mikayla-maki
Copy link
Contributor

"recursion limit reached while expanding #[test]"

That is caused by doing use crate::*;, which currently doesn't work inside GPUI.

@JunkuiZhang
Copy link
Contributor Author

"recursion limit reached while expanding #[test]"

That is caused by doing use crate::*;, which currently doesn't work inside GPUI.

I have changed that, thanks!

@mikayla-maki mikayla-maki merged commit f495ee0 into zed-industries:main Mar 26, 2024
8 checks passed
@mikayla-maki
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants