Start on adding support for editing via the assistant panel #14795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change simplifies the assist method by removing the need for selected_messages. Instead, it always uses the last valid message as the basis for the assistant's response. This approach streamlines the interaction flow and makes the behavior more predictable. The method now returns an Option<MessageAnchor> for the new user message, allowing callers to easily handle cases where assistance isn't possible. This change improves error handling and provides better feedback to the UI. Co-Authored-By: Nathan <[email protected]>
Co-Authored-By: Nathan <[email protected]>
Co-Authored-By: Nathan <[email protected]>
TODO: 1. Deduplicate symbol locations when a symbol is repeated, or we have a parent that contains it 2. When appending or prepending to a symbol, show the leading / trailing lines 3. Open multibuffers as previews without switching focus 4. Close preview tabs when cursor moves out of a step
This commit updates the edit step locations functionality in the assistant panel: - Renames `EditLocation` to `EditStepLocation` for clarity - Updates `locations_multibuffer` and `locations` methods to handle multiple ranges per buffer - Implements deduplication and sorting of ranges for each buffer - Adds an `intersects` method to `AnchorRangeExt` for range comparison These changes improve the handling of edit step locations, allowing for more efficient and accurate representation of edit operations across multiple files. Co-Authored-By: Nathan <[email protected]>
Co-Authored-By: Nathan <[email protected]>
We want to add optional @OPEN and @close captures to help with appending/prepending symbols in the correct location beneath parent outline items with braces or other open/close delimiters. This causes items to be matched out of order as we wait to match the closing }. Co-Authored-By: Nathan <[email protected]>
This will be useful to append/prepend children via the assistant.
Co-Authored-By: Nathan <[email protected]>
Co-Authored-By: Nathan <[email protected]>
Co-Authored-By: Nathan <[email protected]>
Co-Authored-By: Nathan <[email protected]>
Co-Authored-By: Nathan <[email protected]>
Co-Authored-By: Nathan <[email protected]>
cla-bot
bot
added
the
cla-signed
# Conflicts: # crates/project/src/project.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this shouldn't have any visible user-facing behavior yet. The feature is incomplete but we wanna merge early to avoid a long-running branch.
Release Notes: