Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply terminal.foreground and terminal.background from theme #14281

Merged
merged 2 commits into from
Jul 13, 2024
Merged

Apply terminal.foreground and terminal.background from theme #14281

merged 2 commits into from
Jul 13, 2024

Conversation

zakj
Copy link
Contributor

@zakj zakj commented Jul 12, 2024 •
edited
Loading

Release Notes:

  • Fixed terminal colors not respecting the theme (#11418).

@cla-bot cla-bot
Copy link

cla-bot bot commented Jul 12, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @zakj on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@zakj
Copy link
Contributor Author

zakj commented Jul 12, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jul 12, 2024
@cla-bot cla-bot
Copy link

cla-bot bot commented Jul 12, 2024

The cla-bot has been summoned, and re-checked this pull request!

SomeoneToIgnore
SomeoneToIgnore reviewed Jul 12, 2024
View reviewed changes
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
Fo;llowing the same logic, can we also use
background_color: Some(theme.colors().terminal_background), a few lines above?

@SomeoneToIgnore SomeoneToIgnore self-assigned this Jul 12, 2024
@zakj
Copy link
Contributor Author

zakj commented Jul 13, 2024

@SomeoneToIgnore Good catch, thanks! I also noticed one another required change.

@zakj zakj changed the title Use terminal.foreground instead of text for terminal Apply terminal.foreground and terminal.background from theme Jul 13, 2024
SomeoneToIgnore
SomeoneToIgnore approved these changes Jul 13, 2024
View reviewed changes
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about right, thank you for spitting this!

@SomeoneToIgnore SomeoneToIgnore merged commit 3a41094 into zed-industries:main Jul 13, 2024
11 checks passed
@zakj zakj deleted the term-fg branch July 13, 2024 18:01
SomeoneToIgnore pushed a commit that referenced this pull request Jul 15, 2024
@zakj @SomeoneToIgnore
Apply terminal.foreground and terminal.background from theme (#14281
71b2902 
)

Release Notes:

- Fixed terminal colors not respecting the theme
([#11418](#11418)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SomeoneToIgnore SomeoneToIgnore SomeoneToIgnore approved these changes

Assignees

@SomeoneToIgnore SomeoneToIgnore

Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zakj @SomeoneToIgnore