Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust list item & pickers spacing #14250

Merged
merged 5 commits into from
Jul 15, 2024
Merged

Adjust list item & pickers spacing #14250

merged 5 commits into from
Jul 15, 2024

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Jul 11, 2024 •
edited
Loading

This PR's goal is to fix the bigger horizontal than vertical padding in list items and pickers. Couldn't find any instance where my changes dramatically worsened different flavors of these components.

Before After
Screenshot 2024-07-11 at 16 42 33 Screenshot 2024-07-11 at 16 42 44
Screenshot 2024-07-11 at 16 43 19 Screenshot 2024-07-11 at 16 43 00
Screenshot 2024-07-11 at 16 43 31 Screenshot 2024-07-11 at 16 43 45
Screenshot 2024-07-11 at 16 43 59 Screenshot 2024-07-11 at 16 44 12

Release Notes:

  • N/A

@danilo-leal danilo-leal self-assigned this Jul 11, 2024
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jul 11, 2024
@zed-industries-bot
Copy link

zed-industries-bot commented Jul 11, 2024 •
edited
Loading

Warnings
⚠️

This PR is missing release notes.

Please add a "Release Notes" section that describes the change:

Release Notes:

- (Added|Fixed|Improved) ... ([#<public_issue_number_if_exists>](https://github.com/zed-industries/zed/issues/<public_issue_number_if_exists>)).

If your change is not user-facing, you can use "N/A" for the entry:

Release Notes:

- N/A

Generated by 🚫 dangerJS against 150bae3

@iamnbutler
Copy link
Member

Looking great!

@danilo-leal you can find the prompt library picker editor in the PickerDelegate impl:

crates/assistant/src/prompt_library.rs > impl PickerDelegate for PromptPickerDelegate > render_editor

@iamnbutler
Copy link
Member

LGTM – feel free to merge when you are ready @danilo-leal

@danilo-leal danilo-leal merged commit e50811c into zed-industries:main Jul 15, 2024
10 checks passed
@danilo-leal danilo-leal deleted the list-item-pickers-spacing-adjustments branch July 15, 2024 13:23
SomeoneToIgnore pushed a commit that referenced this pull request Jul 15, 2024
@danilo-leal @SomeoneToIgnore
Adjust list item & pickers spacing (#14250)
3525617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamnbutler iamnbutler iamnbutler approved these changes

@maxdeviant maxdeviant Awaiting requested review from maxdeviant

Assignees

@danilo-leal danilo-leal

Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danilo-leal @zed-industries-bot @iamnbutler