Allow Zed to run under multiple user accounts simultaneously #14143
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @samsonjs on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Also I've never written a line of Rust before in my life so my feelings won't be hurt if you have any feedback about basic stuff in the code. Please feel free to critique anything in here to your heart's content. |
You can use |
crates/zed/src/zed/only_instance.rs
Outdated
| }; | ||
| let user_id = Uid::current().as_raw() as u16; |
There was a problem hiding this comment.
Are UIDs guaranteed to be consecutive?
There was a problem hiding this comment.
Good point, they are definitely not always consecutive. There might be gaps so it's safer to have a bigger buffer in between ports for each release channel.
|
@osiewicz Thank you very much for the pointers! I'll see what I can come up with now |
Also swaps out the unistd call for the users crate to make this build on Windows as well.
|
I was able to properly test this out by commenting out the check that treats all dev builds as the only instance and I think it's sound now. Rather than using unistd I swapped in the users crate to fix the failing Windows build. I'm not certain about the addition overflowing behaviour in here and maybe it's worth having a check for that, any advice on that is welcome. It seems like a real corner case but I'm less certain about Windows than Unix on this one. |
|
Ok so this users crate doesn't work on Windows. I'm away right now but I have a Windows PC at home so when I'm back I can try to find some time to figure this out. |
|
Hi, I implemented single instance on Windows using a different approach #15371 . Any advice or suggestions? |
|
Hey, how about using something like |
|
Thanks @osiewicz that looks like the ticket! I'm able to grab the user's
Any advice is appreciated and I'll try to find a bit of time to figure it out on my own as well. |
Also a rust novice, but I think 
|
|
Yep that does the trick, thank you! |
|
Ok I got my hands on a Windows box and I think this is finally gonna work 🤞 |
|
Thanks! |
|
Thank you all for the assistance! I like Zed a lot so far! |
Closes #4607
This is an attempt to enable Zed to run under multiple user accounts on the same Mac, because it's a blocker to me really giving Zed a fair shot at being my primary editor.
According to some helpful info from @ForLoveOfCats in #4607 the main reason why this doesn't work is because Zed is using a Unix socket or maybe a TCP socket with a hard-coded path and/or port. To me it looks like it's a TCP socket so I tried changing that code in here, but I'm stuck at trying to test it out because running
target/debug/zedortarget/release/zedseems to behave differently than running an actual app bundle. I had no luck copying the binary over to /Applications/Zed.app/Contents/MacOS/zed because it can't find WebRTC.framework which resides at a different relative path in the app bundle.If this seems like a desirable change to the core team then I'm looking for some guidance on how to build an app bundle or otherwise test out this change, or a nudge in the correct direction if I'm way off base with my current approach.
Release Notes: