Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #14106 Windows title bar broken #14122

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

huacnlee
Copy link
Contributor

@huacnlee huacnlee commented Jul 11, 2024

Release Notes:

  • N/A

Fix #14106

Sorry, the previous change in #14063 I have made a mistake. I shouldn't have changed the previous logic.

- if !state_ptr.hide_title_bar {
  if state_ptr.hide_title_bar {

Test

2024-07-11.084223.mp4

And the popup window limit is still works.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jul 11, 2024
@huacnlee huacnlee changed the title Fix #14106 Windows title bar broken. Fix #14106 Windows title bar broken Jul 11, 2024
@ConradIrwin ConradIrwin merged commit 5bc3846 into zed-industries:main Jul 11, 2024
13 checks passed
@ConradIrwin
Copy link
Collaborator

no worries!

@huacnlee huacnlee deleted the fix-14106 branch July 25, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Titlebar buttons are completely broken and the window cannot be moved (Windows 11)
2 participants