gpui: Fix popup kind window support on Windows #14063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
|
Thanks! |
ConradIrwin
pushed a commit
that referenced
this pull request
Jul 11, 2024
Release Notes: - N/A ---- Fix #14106 Sorry, the previous change in #14063 I have made a mistake. I shouldn't have changed the previous logic. ```diff - if !state_ptr.hide_title_bar { if state_ptr.hide_title_bar { ``` ## Test https://github.com/zed-industries/zed/assets/5518/e03fbcac-be6b-4a9d-8937-d3b5e236b564 And the popup window limit is still works.
|
I'm wondering why the window extended style was changed from |
|
... Sorry. This is what I tried to change when I was repeatedly experimenting with the Popup window style. I forgot to revert it before a push. There was no need to modify it originally. |
ConradIrwin
pushed a commit
that referenced
this pull request
Jul 11, 2024
Release Notes: - N/A @ConradIrwin we must revert this little change. #14063 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes:
Continue #14044 for Windows
The problem
The
cx.open_windowmethod has provided us awindow_kindoption to allows creating a Popup kind. This behavior can work on macOS, the popup kind window have no-border, no-shadow, no-resize, and followed theis_movableif present true it can't move.This PR to fix those supports on Windows.
The border and shadow still exist, I have tried to use WS_POPUP window_style, but it will crash:
So I just make a simple change, to use
WS_EX_TOOLWINDOWthis can disable resize, and connectis_movabletohandle_hit_test_msgto disable move, and also no Status Bar icon.Before
before.mp4
After
after.mp4