Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in show_whitespaces docs in default setting #13735

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Fix typo in show_whitespaces docs in default setting #13735

merged 2 commits into from
Jul 2, 2024

Conversation

andreinonea
Copy link
Contributor

Release Notes:

  • N/A

@cla-bot cla-bot
Copy link

cla-bot bot commented Jul 2, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @andreinonea on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@andreinonea
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jul 2, 2024
@cla-bot cla-bot
Copy link

cla-bot bot commented Jul 2, 2024

The cla-bot has been summoned, and re-checked this pull request!

SomeoneToIgnore
SomeoneToIgnore approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for noticing.

Would you mind also adjusting the corresponding section here?

zed/docs/src/configuring-zed.md

Line 1126 in 51ee60b

4. `boundaries`

@SomeoneToIgnore SomeoneToIgnore self-assigned this Jul 2, 2024
@maxdeviant maxdeviant changed the title default-settings: fix typo in show_whitespaces doc Fix typo in show_whitespaces docs in default setting Jul 2, 2024
@andreinonea
Copy link
Contributor Author

andreinonea commented Jul 2, 2024 •
edited
Loading

Thank you for noticing.

Would you mind also adjusting the corresponding section here?

zed/docs/src/configuring-zed.md

Line 1126 in 51ee60b

4. `boundaries`

Sure thing! I didn't think to check there as well, but I will keep it in mind for the future. Thanks!

SomeoneToIgnore
SomeoneToIgnore approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you.

We have a separation, the json file is what Zed bundles with itself, and it serves as an "internal documentation", while the md file is something that's eventually published to zed.dev , separately from Zed itself.

@SomeoneToIgnore SomeoneToIgnore merged commit 8dd7c2c into zed-industries:main Jul 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SomeoneToIgnore SomeoneToIgnore SomeoneToIgnore approved these changes

Assignees

@SomeoneToIgnore SomeoneToIgnore

Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreinonea @SomeoneToIgnore