Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auto-rename ranges with special characters #13719

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Fix auto-rename ranges with special characters #13719

merged 2 commits into from
Jul 1, 2024

Conversation

kriskw1999
Copy link
Contributor

@kriskw1999 kriskw1999 commented Jul 1, 2024 •
edited by maxdeviant
Loading

Release Notes:

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jul 1, 2024
@maxdeviant maxdeviant changed the title FIX: Autorename ranges with special chars Fix auto-rename ranges with special characters Jul 1, 2024
@kriskw1999
Copy link
Contributor Author

@osiewicz I ended up by using the char_kind as suggested since solves the issue in all the cases that I spotted.

BTW if you think that for any reason there is a need to add the word_pattern let me know!

Thanks for the support!

@osiewicz
Copy link
Contributor

osiewicz commented Jul 1, 2024

Ehh, idk if we need word_pattern for now honestly. tsserver uses a pretty lenient regex in https://github.com/microsoft/TypeScript/blame/962389313f7e80b873cf4935fd7faf749d2e369c/src/services/services.ts#L2763 (with a rationale in microsoft/TypeScript#53934) but I feel like we can start out by being a bit too strict and then adjust as needed.

osiewicz
osiewicz approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@osiewicz osiewicz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! (or "dzięki" ;) )

@osiewicz osiewicz merged commit 0eb26d2 into zed-industries:main Jul 1, 2024
11 checks passed
@osiewicz osiewicz self-assigned this Jul 1, 2024
@notpeter notpeter mentioned this pull request Jul 3, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osiewicz osiewicz osiewicz approved these changes

Assignees

@osiewicz osiewicz

Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kriskw1999 @osiewicz