Store starts open state of outline panel #13601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We require contributors to sign our Contributor License Agreement, and we don't have @yongkangchen on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
SomeoneToIgnore
approved these changes
Jun 27, 2024
No, because the project panel only opens when there is a project opened. |
1 task
1 task
SomeoneToIgnore
pushed a commit
that referenced
this pull request
Jul 1, 2024
- Fixed issue where outline panel remains open despite being closed before window close. Before the release of Outline Panel feature, everything works fine. But after that, the outline panel keeps open. It's very annoy that I only want to edit a simple file. Event I close it before I close the window. The active state of this panel didn't stored. ### Description: Before the introduction of the Outline Panel feature, the application behaved as expected. However, with the addition of the Outline Panel, an issue arose where the panel would persistently remain open. This behavior was observed even when manually closing the panel before closing the application window. The problem stemmed from the inactive state of the panel not being stored properly. This fix addresses the issue by ensuring that the panel's active state is correctly stored and retrieved, thereby improving user experience and preventing unnecessary persistence of the panel's visibility. ### Screen Records #### Before Release of Outline Panel https://github.com/zed-industries/zed/assets/704762/2a222c70-c6d7-4472-9f27-7868d1786a5f #### After Release of Outline Panel https://github.com/zed-industries/zed/assets/704762/69c16a5d-beed-4d4a-8341-83c53f6a6713 #### After Fixing This Issue https://github.com/zed-industries/zed/assets/704762/f51c5df7-54e3-4a62-ac54-b5d12cfe69d1 ### Release Notes: - Persist outline panel open state to avoid opening it on Zed startup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes:
Before the release of Outline Panel feature, everything works fine. But after that, the outline panel keeps open. It's very annoy that I only want to edit a simple file. Event I close it before I close the window. The active state of this panel didn't stored.
Description:
Before the introduction of the Outline Panel feature, the application behaved as expected. However, with the addition of the Outline Panel, an issue arose where the panel would persistently remain open. This behavior was observed even when manually closing the panel before closing the application window. The problem stemmed from the inactive state of the panel not being stored properly. This fix addresses the issue by ensuring that the panel's active state is correctly stored and retrieved, thereby improving user experience and preventing unnecessary persistence of the panel's visibility.
Screen Records
Before Release of Outline Panel
before_issue.mov
After Release of Outline Panel
before.mov
After Fixing This Issue
fixed_1080p.mov