Update One Light modified color #12143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
|
The new color looks way too dark, to me. |
|
For reference, this is how it appears in vscode Maybe taking something between the two? |
maxdeviant
changed the title
|
as a light mode user, this change is almost a must. but i agree the first one is a bit too dark, i like the one in-between 👍 the green colour on one light is also a bit too bright, toning it down for a bit more contrast would be also nice. |
|
Apologies, I meant to get to this earlier – while I somewhat agree the color isn't great, I also recognize the current situation is worse than not great. Let's merge this change for now and I'll take another look when I get to One Light cleanup. Thanks for the contribution! Apologies it took me this long to get to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes:
modifiedcolor on the one-light color theme to a more readable valueThe current color in the file tree for modified files is basically unreadable in the default light mode
This change just changes the color to match that of the one-light theme present in vscode
old proposal: https://github.com/zed-industries/zed/assets/50590465/b4dc4030-bcd8-429a-84b8-2744e213e492new proposal:
This does have a side-effect of changing the modified color on the side in the editor, but personally I think this change is negligable.