Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return an error from project index tool when embedding query fails #11264

Merged
merged 1 commit into from
May 1, 2024

Conversation

maxbrunsfeld
Copy link
Collaborator

@maxbrunsfeld maxbrunsfeld commented May 1, 2024

Previously, a failure to embed the search query (due to a rate limit error) would appear the same as if there were no results.

  • Avoid repeatedly embedding the search query for each worktree
  • Unify tasks for searching all worktree

Release Notes:

  • N/A

* Avoid repeatedly embedding the search query for each worktree
* Unify tasks for searching all worktree
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label May 1, 2024
@maxbrunsfeld maxbrunsfeld merged commit 5831d80 into main May 1, 2024
9 checks passed
@maxbrunsfeld maxbrunsfeld deleted the surface-rate-limit-errors branch May 1, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant