Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font size will be reset on saving settings.json #5359

Closed
exalted opened this issue Jun 20, 2022 · 6 comments
Closed

Font size will be reset on saving settings.json #5359

exalted opened this issue Jun 20, 2022 · 6 comments
Labels
defect [core label] duplicate Additional reports of an existing issue font Font feedback for readability, size, style, etc setting Feedback for preferences, configuration, etc

Comments

@exalted
Copy link
Contributor

exalted commented Jun 20, 2022 •
edited
Loading

To Reproduce

  1. Increase the font size.
  2. Open settings.json and hit save.
  3. Observe that editor's font size has been reset to whatever the default value is.

Expected behavior

I'd expect the font size to persist, considering I didn't change anything related to the font size (my settings.json doesn't contain anything related to the font size to begin with).

Environment:

  • Architecture: arm64
  • macOS Version: 12.4 (21F79)
  • Zed Version: 0.39.0
@exalted exalted added defect [core label] triage Maintainer needs to classify the issue labels Jun 20, 2022
@JosephTLyons
Copy link
Contributor

JosephTLyons commented Jun 20, 2022 •
edited
Loading

Hey @exalted, how are you increasing the font size in step 1? Are you using cmd- ?

@exalted
Copy link
Contributor Author

exalted commented Jun 20, 2022 •
edited
Loading

Cmd - /-

@exalted
Copy link
Contributor Author

exalted commented Jun 20, 2022 •
edited by notpeter
Loading

Possibly related to

@iamnbutler
Copy link
Member

We chatted about this. We agree there are issues with the way we are dealing with font size, and we are going to rethink it overall. Waiting to take a pass at overhaul this entirely, so might be a bit!

@iamnbutler iamnbutler removed the triage Maintainer needs to classify the issue label Jun 20, 2022
@JosephTLyons
Copy link
Contributor

Possibly related to #5380

I think these are the same thing. In this issue, the settings are being reloaded when you save on the settings file, in the other issue, the settings are being reloaded when the editor loads up.

@as-cii as-cii mentioned this issue Aug 1, 2022
Closed
46 tasks
@JosephTLyons JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024
@JosephTLyons
Copy link
Contributor

Closing this out as a duplicate of:

@JosephTLyons JosephTLyons added setting Feedback for preferences, configuration, etc duplicate Additional reports of an existing issue font Font feedback for readability, size, style, etc labels Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect [core label] duplicate Additional reports of an existing issue font Font feedback for readability, size, style, etc setting Feedback for preferences, configuration, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@exalted @iamnbutler @JosephTLyons