Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add path globs to LanguageMatcher #15847

Closed
1 task done
aohoyd opened this issue Aug 6, 2024 · 1 comment
Closed
1 task done

Add path globs to LanguageMatcher #15847

aohoyd opened this issue Aug 6, 2024 · 1 comment
Labels
support User support (non-defect troubleshooting, documentation, etc)

Comments

@aohoyd
Copy link

aohoyd commented Aug 6, 2024

Check for existing issues

  • Completed

Describe the feature

Inspired by discussion in zed-industries/extensions#746

The problem

Now the only way to choose a language for file is path_suffix configuration option in

zed/crates/language/src/language.rs

Line 616 in 7cef5b2

pub struct LanguageMatcher {
. Sometimes the language to use is not determined by file's extension but file's location or it's name.

Proposed fix

Extend LanguageMatcher with path_globs field with a list of globs matching file path.

If applicable, add mockups / screenshots to help present your vision of the feature

No response
@aohoyd aohoyd added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Aug 6, 2024
@osiewicz
Copy link
Contributor

osiewicz commented Aug 6, 2024

We can already use globs for matching languages: #12043

@notpeter notpeter added support User support (non-defect troubleshooting, documentation, etc) and removed enhancement [core label] triage Maintainer needs to classify the issue admin read Pending admin review labels Aug 6, 2024
@notpeter notpeter closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
support User support (non-defect troubleshooting, documentation, etc)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@notpeter @osiewicz @aohoyd