Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on "View Dependency Licenses" #14302

Closed
1 task done
captn3m0 opened this issue Jul 12, 2024 · 4 comments · Fixed by #14561
Closed
1 task done

Crash on "View Dependency Licenses" #14302

captn3m0 opened this issue Jul 12, 2024 · 4 comments · Fixed by #14561
Labels
defect [core label] linux linux-wayland Linux Wayland panic / crash [core label]

Comments

@captn3m0
Copy link
Contributor

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

  • Launch Zed
  • Click "View Dependency Licenses"

Zed crashes

Environment

Zed: v0.143.6 (Zed)
OS: Linux Wayland fedora-asahi-remix 40
Memory: 7.3 GiB
Architecture: aarch64

Package installed via the recommended Terra Fedora repos.

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

Not on Mac, but here's the log from the crash.

Zed.log
zed --foreground
[2024-07-12T11:45:01 05:30 ERROR theme] theme not found: Catppuccin Latte
[2024-07-12T11:46:30 05:30 ERROR zed::reliability] {
  "thread": "main",
  "payload": "called `Option::unwrap()` on a `None` value",
  "location_data": {
    "file": "/builddir/build/BUILD/zed-0.143.6/crates/util/src/util.rs",
    "line": 570
  },
  "backtrace": [
    "__libc_start_call_main",
    "__libc_start_main_alias_2"
  ],
  "app_version": "0.143.6",
  "release_channel": "Zed",
  "os_name": "Linux Wayland",
  "os_version": "fedora-asahi-remix 40",
  "architecture": "aarch64",
  "panicked_on": 1720764990856,
  "installation_id": "6017871e-82dd-4ebb-a8c9-29ca407f89c7",
  "session_id": "25cb3e5b-27e7-41b6-97e9-98b083fd74ee"
}
@captn3m0 captn3m0 added admin read Pending admin review defect [core label] panic / crash [core label] triage Maintainer needs to classify the issue labels Jul 12, 2024
@notpeter notpeter added linux linux-wayland Linux Wayland and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jul 13, 2024
@captn3m0
Copy link
Contributor Author

Can replicate this on a x86_64 setup as well:

Zed: v0.143.7 (Zed)
OS: Linux Wayland arch unknown
Memory: 15 GiB
Architecture: x86_64
{
  "thread": "main",
  "payload": "called `Option::unwrap()` on a `None` value",
  "location_data": {
    "file": "/crates/util/src/util.rs",
    "line": 570
  },
  "backtrace": [
    "__libc_start_main"
  ],
  "app_version": "0.143.7",
  "release_channel": "Zed",
  "os_name": "Linux Wayland",
  "os_version": "arch unknown",
  "architecture": "x86_64",
  "panicked_on": 1720928631318,
  "installation_id": "bcf6ecd5-eb76-4382-b842-6a5eab92f754",
  "session_id": "c5afacd9-0209-44b4-a042-9a77232eede3"
}

@DragonDev1906
Copy link

This also happens with x11

{
  "thread": "main",
  "payload": "called `Option::unwrap()` on a `None` value",
  "location_data": {
    "file": "/crates/util/src/util.rs",
    "line": 570
  },
  "backtrace": [
    "__libc_start_main"
  ],
  "app_version": "0.143.7",
  "release_channel": "Zed",
  "os_name": "Linux X11",
  "os_version": "arch unknown",
  "architecture": "x86_64",
  "panicked_on": 1721036019823,
  "installation_id": "7be46a5a-263c-43a2-9fa9-c6e55983dfa5",
  "session_id": "5c7b25d2-85a6-46a5-85c9-56ce379950d6"
}

@graphixillusion
Copy link

Happens on Windows too.

mrnugget added a commit that referenced this issue Jul 16, 2024
Turns out that the existing CI step for Nightly did create the licenses
and they have been baked into X86 builds ever since, because our
builders are stateful.

On ARM machines, the licenses wouldn't exist in the binary because we
called `script/generate-licenses` too late in `scripts/bundle-linux`,
after the binary had been created.

This removes the duplication and generates the licenses once, before the
binary is created.

Fixes #14302.
@graphixillusion
Copy link

This bug still happening on Windows build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect [core label] linux linux-wayland Linux Wayland panic / crash [core label]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants