Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcut for reverse history search in terminal triggers symbol view instead #14033

Closed
1 task done
GyozaGuy opened this issue Jul 9, 2024 · 2 comments
Closed
1 task done

Shortcut for reverse history search in terminal triggers symbol view instead #14033

GyozaGuy opened this issue Jul 9, 2024 · 2 comments
Labels
keymap / key binding Feedback for keyboard shortcuts, key mapping, etc support User support (non-defect troubleshooting, documentation, etc)

Comments

@GyozaGuy
Copy link

GyozaGuy commented Jul 9, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Starting with version 0.143.5, pressing Ctrl R in the terminal to trigger a reverse history search triggers the symbols view instead. Previous to this version, the symbols shortcut was Super R.

Environment

Zed: v0.143.5 (Zed Preview)
OS: Linux X11 ubuntu 24.04
Memory: 31 GiB
Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

Ctrl R should not trigger the symbols view if the terminal is currently focused. Ideally, any well-known terminal shortcuts should probably not trigger other Zed features while the terminal is focused.

If applicable, attach your Zed.log file to this issue.

Zed.log





















 




















@GyozaGuy
GyozaGuy
added

admin read

Pending admin review

defect

[core label]

triage

Maintainer needs to classify the issue
labels
Jul 9, 2024












@notpeter












 








Copy link
 

 







Contributor








notpeter

commented
Jul 13, 2024

•






edited







 Loading





















Yeah, a few folks have run into this. I'm not sure the correct answer here as some people clearly people expect ctrl-w to be passed to the terminal (as it is currently) while others expect ctrl-w to close the terminal tab:



We currently have two key combinations that passthru by default in terminal:







zed/assets/keymaps/default-linux.json




Lines 251 to 257
in
89fbd65











 { 





 "context": "Terminal", 





 "bindings": { 





 "ctrl-w": ["terminal::SendKeystroke", "ctrl-w"], 





 "ctrl-e": ["terminal::SendKeystroke", "ctrl-e"] 





 } 





 }, 











You can add more to do the same in your ~/.config/zed/keymap.json:


[
  {
    "context": "Terminal",
    "bindings": {
      "ctrl-r": ["terminal::SendKeystroke", "ctrl-r"]
    }
  }
]



If this doesn't work, let me know.

































 























@notpeter
notpeter
mentioned this issue

Jul 13, 2024










Open


















@notpeter
notpeter
added

keymap / key binding

Feedback for keyboard shortcuts, key mapping, etc

support

User support (non-defect troubleshooting, documentation, etc)
and removed

defect

[core label]

triage

Maintainer needs to classify the issue

admin read

Pending admin review
labels
Jul 13, 2024












@GyozaGuy












 








Copy link
 

 







Author




















That works perfectly, thanks!

































 




















@notpeter
notpeter
mentioned this issue

Jul 15, 2024










Closed

















1 task
















 










Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment









 







Assignees



No one assigned







Labels





keymap / key binding

Feedback for keyboard shortcuts, key mapping, etc

support

User support (non-defect troubleshooting, documentation, etc)










Projects







None yet


 







Milestone


No milestone












Development



No branches or pull requests


 











2 participants





@notpeter
 
@GyozaGuy