Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not autocomplete in Python when using ' instead of " #13972

Closed
1 task done
xtanion opened this issue Jul 9, 2024 · 3 comments · Fixed by #14014
Closed
1 task done

Does not autocomplete in Python when using ' instead of " #13972

xtanion opened this issue Jul 9, 2024 · 3 comments · Fixed by #14014
Labels
autocompletions Feedback for code completions in the editor defect [core label] editor Feedback for code editing, formatting, editor iterations, etc python Python programming language support

Comments

@xtanion
Copy link

xtanion commented Jul 9, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

In python string can be defined by either "string" or 'string'
the later doesn't autocompletes in Zed as of now

Environment

Mac OS | 14.5 (23F79)

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log
@xtanion xtanion added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Jul 9, 2024
@notpeter
Copy link
Contributor

notpeter commented Jul 9, 2024

Interesting. Single quote has close = false

brackets = [
{ start = "{", end = "}", close = true, newline = true },
{ start = "[", end = "]", close = true, newline = true },
{ start = "(", end = ")", close = true, newline = true },
{ start = "\"", end = "\"", close = true, newline = false, not_in = ["string"] },
{ start = "'", end = "'", close = false, newline = false, not_in = ["string"] },
]

It appears to have been this way since it was introduced in 34351c0.
@maxbrunsfeld Was this intentional?

Related:

@notpeter notpeter added editor Feedback for code editing, formatting, editor iterations, etc python Python programming language support autocompletions Feedback for code completions in the editor labels Jul 9, 2024
@maxbrunsfeld
Copy link
Collaborator

@notpeter thanks for raising that. I do not think it was intentional, I probably accidentally kept that from the Rust configuration (in which single ticks are often unpaired). Want to make that change to set close to true?

@notpeter notpeter removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jul 9, 2024
@notpeter
Copy link
Contributor

notpeter commented Jul 9, 2024

This fix will be in tomorrow's Zed Preview release (v0.144.x) which will become Zed stable a week from Wednesday (2024-07-17). Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocompletions Feedback for code completions in the editor defect [core label] editor Feedback for code editing, formatting, editor iterations, etc python Python programming language support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants