Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surround with quotes does not work when using a keyboard layout that uses dead keys #13838

Open
1 task done
mentz opened this issue Jul 4, 2024 · 0 comments
Open
1 task done
Labels
defect [core label] internationalization Feedback for human language support, translations, etc keymap / key binding Feedback for keyboard shortcuts, key mapping, etc

Comments

@mentz
Copy link

mentz commented Jul 4, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

I'm using an ANSI US keyboard but with the language set to pt-BR. pt-BR uses dead keys, meaning that if I want to output a single quote ' I need to press and release the ' key, then press and release <space>. If I select an entire string and press the sequence of keys to output ', I expect that the editor surrounds the selection in single quotes, but instead it just replaces the selection with ''. This does not happen when using a language that does not use dead keys for outputting quotes, like en-US, as shown in the demo.

Screen.Recording.2024-07-04.at.16.21.24.mov

Environment

Zed: v0.142.4 (Zed)
OS: macOS 14.5.0
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

Zed.log
@mentz mentz added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Jul 4, 2024
@notpeter notpeter added internationalization Feedback for human language support, translations, etc keymap / key binding Feedback for keyboard shortcuts, key mapping, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect [core label] internationalization Feedback for human language support, translations, etc keymap / key binding Feedback for keyboard shortcuts, key mapping, etc
Projects
None yet
Development

No branches or pull requests

2 participants