Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supermaven is unusable in zed #13039

Closed
1 task done
kynnyhsap opened this issue Jun 14, 2024 · 4 comments · Fixed by #13884
Closed
1 task done

Supermaven is unusable in zed #13039

kynnyhsap opened this issue Jun 14, 2024 · 4 comments · Fixed by #13884
Labels
ai Improvement related to Assistant, Copilot, or other AI features defect [core label] inline completion supermaven

Comments

@kynnyhsap
Copy link

kynnyhsap commented Jun 14, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

in vscode supermaven suggest completions at the end of the line and when you hit tab it replaces the whole line to the end.

Screen.Recording.2024-06-14.at.12.55.08.mov

but in zed suggestions is displayed in the middle of the line where the cursor at and when you hit tab it only inserts in the middle

Screen.Recording.2024-06-14.at.12.54.10.mov

this ergonomic issue makes supermavan unusable in zed because supermaven suggestions are too fast and my code jumps all the time

Environment

Zed: v0.141.0 (Zed Nightly 1248788)
OS: macOS 14.1.1
Memory: 32 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

@kynnyhsap kynnyhsap added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Jun 14, 2024
@notpeter notpeter added ai Improvement related to Assistant, Copilot, or other AI features autocompletions Feedback for code completions in the editor and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jun 14, 2024
@JosephTLyons JosephTLyons added inline completion supermaven and removed autocompletions Feedback for code completions in the editor labels Jun 17, 2024
@xcrap
Copy link

xcrap commented Jul 3, 2024

Yes, this completion to the end of the line without replacing or not repeating the end code makes it practically unusable.

kevmo314 added a commit to kevmo314/zed that referenced this issue Jul 5, 2024
Configures inline completions to delete the remaining text on the given line. Closes zed-industries#13039.
@siddarthvader
Copy link

same issue, it makes the whole editor unresponsive as well, any help or suggestion most welcome.

@jameelsocorro
Copy link

Same issue. This is the only one I'm waiting to go full zed.

@xcrap
Copy link

xcrap commented Jul 17, 2024

The tab is causing my some problems, I want to add tabs to insert code and it starts completing when I just want to add tab, this really needs some polishing. :)

@rgbkrk rgbkrk closed this as completed in a20e92a Jul 22, 2024
CharlesChen0823 pushed a commit to CharlesChen0823/zed that referenced this issue Jul 29, 2024
…ndustries#13884)

Configures inline completions to delete the remaining text on the given
line. This doesn't affect the github copilot inline completion provider
since it seems to only generate suggestions if the cursor is at the end
of the line but fixes the usability issues related to Supermaven.




https://github.com/user-attachments/assets/1b8bc9a3-4666-4665-a436-96e4beee01bb





Release Notes:

- Fixed zed-industries#13039

---------

Co-authored-by: Antonio Scandurra <[email protected]>
Co-authored-by: Conrad Irwin <[email protected]>
kevmo314 added a commit to kevmo314/zed that referenced this issue Jul 29, 2024
…ndustries#13884)

Configures inline completions to delete the remaining text on the given
line. This doesn't affect the github copilot inline completion provider
since it seems to only generate suggestions if the cursor is at the end
of the line but fixes the usability issues related to Supermaven.




https://github.com/user-attachments/assets/1b8bc9a3-4666-4665-a436-96e4beee01bb





Release Notes:

- Fixed zed-industries#13039

---------

Co-authored-by: Antonio Scandurra <[email protected]>
Co-authored-by: Conrad Irwin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai Improvement related to Assistant, Copilot, or other AI features defect [core label] inline completion supermaven
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants