Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows?] Ui font clipping top/bottom #12737

Closed
1 task done
MolotovCherry opened this issue Jun 6, 2024 · 4 comments · Fixed by #13854
Closed
1 task done

[Windows?] Ui font clipping top/bottom #12737

MolotovCherry opened this issue Jun 6, 2024 · 4 comments · Fixed by #13854
Labels
defect [core label] font Font feedback for readability, size, style, etc project panel Feedback for files tree view windows

Comments

@MolotovCherry
Copy link
Contributor

MolotovCherry commented Jun 6, 2024 •
edited
Loading

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Ui font size 14 is not cut, size 15 is. Unknown if this is Windows related or not, but it might be Windows specific

Don't know if this is related either, but my resolution is 3840x2160 @ 200% scale

{
  "buffer_font_size": 11,
  "buffer_font_family": "FiraCode NF",
  "ui_font_size": 14, // <-- change to 15
}

14 ✅

image

15 🚫 Notice the subtle clipping on the top and bottom

image

image

Environment

Zed: v0.140.0 (Zed Dev a574036)
OS: Windows 10.0.22631
Memory: 63.8 GiB
Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response
@MolotovCherry MolotovCherry added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Jun 6, 2024
@MolotovCherry MolotovCherry changed the title Ui font clipping top/bottom [Windows?] Ui font clipping top/bottom Jun 6, 2024
@Moshyfawn Moshyfawn added windows project panel Feedback for files tree view font Font feedback for readability, size, style, etc and removed triage Maintainer needs to classify the issue labels Jun 7, 2024
@Moshyfawn
Copy link
Member

Can't seem to repo on MacOS.

@github-actions github-actions bot mentioned this issue Jun 8, 2024
Open
@JosephTLyons JosephTLyons removed the admin read Pending admin review label Jun 10, 2024
@JunkuiZhang JunkuiZhang mentioned this issue Jul 5, 2024
Merged
@JunkuiZhang
Copy link
Contributor

#13854 may fix this issue. If not, please let me know.

@MolotovCherry
Copy link
Contributor Author

MolotovCherry commented Jul 5, 2024 •
edited
Loading

#13854 may fix this issue. If not, please let me know.

@JunkuiZhang
I compiled and tested out your branch on my machine. I cannot reproduce the issue afterwards! Looks like that solved it.

@Moshyfawn Moshyfawn reopened this Jul 5, 2024
@JunkuiZhang
Copy link
Contributor

@MolotovCherry That's great :)

mikayla-maki pushed a commit that referenced this issue Jul 9, 2024
@JunkuiZhang
windows: Fix font clipping issue (#13854)
8f29ff8 
Closes #12737 . Left before this PR, right after.

![Screenshot 2024-07-05
180308](https://github.com/zed-industries/zed/assets/14981363/437baec3-2672-4b19-8595-17a6c564506e)


Release Notes:

- Fixed font rendering clipping issue on Windows.(#12737 )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect [core label] font Font feedback for readability, size, style, etc project panel Feedback for files tree view windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

windows: Fix font clipping issue JunkuiZhang/zed
4 participants
@MolotovCherry @JunkuiZhang @Moshyfawn @JosephTLyons