Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsx language disappear after selecting it in windows #12208

Closed
1 task done
Xenos-the-stupid opened this issue May 23, 2024 · 3 comments · Fixed by #13893
Closed
1 task done

tsx language disappear after selecting it in windows #12208

Xenos-the-stupid opened this issue May 23, 2024 · 3 comments · Fixed by #13893
Labels
defect [core label] language An umbrella label for all programming languages syntax behaviors tsx TypeScript JSX support windows

Comments

@Xenos-the-stupid
Copy link

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

the tsx choice in the languages menu disappear after selecting it forever, the fact is that there is more issues like no highlight for tsx files

here what it looks like
https://github.com/zed-industries/zed/assets/123704726/0b69bcfd-076b-46ce-af2b-8eb1f002c1d9

and for the tsx syntax
Zed_HJ1uyV3h7x

Environment

Zed: v0.138.0 (Zed Dev feea607)
OS: Windows 10.0.22631
Memory: 6.8 GiB
Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

Zed_6oX7VhGomn.mp4

Zed_HJ1uyV3h7x

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response
@Xenos-the-stupid Xenos-the-stupid added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels May 23, 2024
@Xenos-the-stupid Xenos-the-stupid changed the title tsx language disappear forever after selecting it in windows tsx language disappear forever in the current session selecting it in windows May 23, 2024
@Xenos-the-stupid Xenos-the-stupid changed the title tsx language disappear forever in the current session selecting it in windows tsx language disappear after selecting it in windows May 23, 2024
@Luca-Ilari
Copy link

I have the same problem

@rohit20v
Copy link

Can't seem to get it working for me either

@d1y
Copy link
Contributor

d1y commented May 23, 2024

This may be a temporary solution

{
  "file_types": {
    "TSX": ["ts"]
  }
}

@JosephTLyons JosephTLyons added windows language An umbrella label for all programming languages syntax behaviors tsx TypeScript JSX support and removed triage Maintainer needs to classify the issue admin read Pending admin review labels May 23, 2024
This was referenced May 24, 2024
Open
Open
@Giuliano1993 Giuliano1993 mentioned this issue Jul 6, 2024
Merged
maxdeviant added a commit that referenced this issue Jul 8, 2024
@Giuliano1993 @maxdeviant
windows: Replace symlinks with files for TSX Tree-sitter queries (#13893
7f50055 
)

Previously to these changes, as stated in the issue, when someone tried
to use TSX as language for the file, the language was not set and it
disappeared from the selectable language list. This was due to the fact
that that the three files were symlinks, and windows couldn't read them.
I replaced them with normal files.

Fixes #12208.

Release Notes:

- N/A

---------

Co-authored-by: Marshall Bowers <[email protected]>
pull bot pushed a commit to RickHuijsmans/zed that referenced this issue Jul 8, 2024
@Giuliano1993 @maxdeviant @pull
windows: Replace symlinks with files for TSX Tree-sitter queries (zed…
29d14c3 
…-industries#13893)

Previously to these changes, as stated in the issue, when someone tried
to use TSX as language for the file, the language was not set and it
disappeared from the selectable language list. This was due to the fact
that that the three files were symlinks, and windows couldn't read them.
I replaced them with normal files.

Fixes zed-industries#12208.

Release Notes:

- N/A

---------

Co-authored-by: Marshall Bowers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect [core label] language An umbrella label for all programming languages syntax behaviors tsx TypeScript JSX support windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

windows: Replace symlinks with files for TSX Tree-sitter queries Giuliano1993/zed
5 participants
@JosephTLyons @d1y @Luca-Ilari @Xenos-the-stupid @rohit20v