Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension-originated color theme is highlighted as "Value not accepted" in config.json #10235

Open
1 task done
osdrv opened this issue Apr 6, 2024 · 2 comments
Open
1 task done

Extension-originated color theme is highlighted as "Value not accepted" in config.json #10235

osdrv opened this issue Apr 6, 2024 · 2 comments
Labels
defect [core label] extension infrastructure Feedback for extensions APIs, creation, management, etc theme Feedback for theme configuration, accessibility, visual issues, etc

Comments

@osdrv
Copy link

osdrv commented Apr 6, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

A color theme from the extensions list called "macOS Classic Theme" is highlighted in the config pane and annotated as "Value is not accepted".

Here is a sequence of steps to reproduce the issue:

  1. Open Extensions pane.
  2. Find extension named macOS Classic Theme (GitHub: https://github.com/huacnlee/zed-theme-macos-classic).
  3. Install it.
  4. An automatic dropdown menu is expected to pop up, prompting to pick one of the 3 theme variations.
  5. Pick the "Light Theme" in the dropdown menu.
  6. The extension is expected to get applied.
  7. Open settings pane.
  8. theme setting is expected to be set to: "theme": "macOS Classic Light".
  9. The theme setting would be highlighted with a hint Value is not accepted. Valid values: ....

Expected behaviour: the color theme is applied with no warning in the config file.

Environment

Zed: v0.129.2 (Zed)
OS: macOS 14.4.1
Memory: 16 GiB
Architecture: aarch64

Extra specs:
Zed version: 0.129.2
Zed build tag: 6866187d1eb2a7886324f77094cbce9469843503
OS version: MacOS 14.4.1 (23E224)
Extension name: macOS Classic Theme
Extension version: 0.0.6

If applicable, add mockups / screenshots to help explain present your vision of the feature

Screenshot 2024-04-06 at 15 38 09

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response
@osdrv osdrv added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Apr 6, 2024
@JosephTLyons JosephTLyons added theme Feedback for theme configuration, accessibility, visual issues, etc extension infrastructure Feedback for extensions APIs, creation, management, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Apr 9, 2024
@github-actions github-actions bot mentioned this issue Apr 13, 2024
Open
@slightlybelowzen
Copy link

slightlybelowzen commented May 17, 2024 •
edited
Loading

I did notice this, but I also saw that restarting zed seems to fix it (I'm guessing it needs to be restarted to find the themes installed from the extensions). Let me know if that fixes it.

If that doesn't work I'll take a look at the code to see what's going on. Another option (this is my preferred one since it doesn't involve downloading a bunch of themes I don't use) is to take the theme I like and just add it the ~/./config/zed/themes/ and use it like that.

You can find the themes you're using here.

@ltsuda
Copy link

ltsuda commented Jul 10, 2024 •
edited
Loading

I

I did notice this, but I also saw that restarting zed seems to fix it (I'm guessing it needs to be restarted to find the themes installed from the extensions). Let me know if that fixes it.

If that doesn't work I'll take a look at the code to see what's going on. Another option (this is my preferred one since it doesn't involve downloading a bunch of themes I don't use) is to take the theme I like and just add it the ~/./config/zed/themes/ and use it like that.

You can find the themes you're using here.

I just got this issue and closing/opening Zed again solved for me. I just installed Linux Stable version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect [core label] extension infrastructure Feedback for extensions APIs, creation, management, etc theme Feedback for theme configuration, accessibility, visual issues, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@osdrv @ltsuda @JosephTLyons @slightlybelowzen