Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All proxied requests are forwarded as POST #462

Closed
tpluscode opened this issue Aug 15, 2024 · 1 comment
Closed

All proxied requests are forwarded as POST #462

tpluscode opened this issue Aug 15, 2024 · 1 comment
Labels
package:sparql-proxy

Comments

@tpluscode
Copy link
Contributor

I noticed that the sparql proxy forwards POST as well as GET as POST to the original service

I think this may have a negative impact on potential caching between trifid and the original endpoint. IMO, GET should be preserved by default
@ludovicm67
Copy link
Member

The sparql-proxy plugin is also a plugin that aims to add support for some missing features from some endpoint solutions in order to have something that other plugins can trust ; sending requests as POST allows support for bigger SPARQL queries as payload.

Solutions like varnish-post exists in case caching is an issue.

I will close this issue for now ; in case there are issues that come from this, we can always consider this in the future.
But I will prefer pushing for something robust and stable, like we have now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:sparql-proxy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tpluscode @ludovicm67