-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rounded border #614
Rounded border #614
Conversation
This is part of #229 |
cc @ibhagwan |
Codecov Report
@@ Coverage Diff @@
## next #614 /- ##
==========================================
- Coverage 39.88% 39.79% -0.10%
==========================================
Files 46 46
Lines 9449 9471 22
==========================================
Hits 3769 3769
- Misses 5680 5702 22
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay to me.
Unfortunately, I can't really test it locally at the moment as I only have i3's fake borders at hand and my test-system doesn't cooperate.
src/win.c
Outdated
// HACK: we reset this so we can query the color once | ||
// we query the color in glx_round_corners_dst0 using glReadPixels | ||
// w->border_col = { -1., -1, -1, -1 }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for consistency, the function is now called glx_round_corners_dst()
and the first value for border_col
is written with a trailing dot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks for pointing it out!
Authored-By: bhagwan <[email protected]> Signed-off-by: Yuxuan Shui <[email protected]>
Signed-off-by: Yuxuan Shui <[email protected]>
@tryone144 I think the approach should work with "fake" borders Edit: ah, no. Because border width detection wouldn't work... Related: i3/i3#4292 |
That’s because rounded borders are only supported on You can turn it off globally with the |
Using all border options doesn't work to disable. It only happens in Openbox's own drawn window and can't use EDIT: That includes this rule |
I took a quick glance at the code, I don’t think the border exclude options were implemented here yet, if you’d like to give these options a try use my fork instead. |
Solved for temporary, back using picom from this commit. |
No description provided.