Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nix flake #1

Merged
merged 8 commits into from
May 26, 2024
Merged

Add nix flake #1

merged 8 commits into from
May 26, 2024

Conversation

Dich0tomy
Copy link
Contributor

@Dich0tomy Dich0tomy commented May 25, 2024

This PR introduces a nix flake & default.nix that builds this rust package which allows nix users to use this package.

For people who want to use this right now, you can refer to this code as follows:

github:ynqa/sig/pull/1/head#default

Or use my fork directly before merge:

github:Dich0tomy/sig/feat/add-nix-build-method

But note that this ref is volatile and the branch will get deleted after this PR gets merged.

Copy link
Owner

@ynqa ynqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dich0tomy Thanks for contributing, I'm not very familiar with nix yet, but I have left comments 📝

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Dich0tomy
Copy link
Contributor Author

I am willing to maintain the Nix code as well.

If you add shell completions, man docs, libraries that rely on system libs (like freetype and such), somebody requests a nix shell and such, ping me and Ill make appropriate changes.

default.nix Show resolved Hide resolved
@ynqa
Copy link
Owner

ynqa commented May 26, 2024

If you add shell completions, man docs, libraries that rely on system libs (like freetype and such), somebody requests a nix shell and such, ping me and Ill make appropriate changes.

@Dich0tomy Cool. That's very helpful, thank you!

Copy link
Owner

@ynqa ynqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ynqa ynqa merged commit 211824b into ynqa:main May 26, 2024
6 checks passed
@k3d3
Copy link

k3d3 commented May 27, 2024

Nice! I can't believe the timing on this - I was just thinking about adding this to my Nix config. Thanks adding this, Dich0tomy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants