Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the "level" column in "log" table to be integer again #5

Merged
merged 2 commits into from
Jan 4, 2019
Merged

Changed the "level" column in "log" table to be integer again #5

merged 2 commits into from
Jan 4, 2019

Conversation

Dzhuneyt
Copy link
Contributor

@Dzhuneyt Dzhuneyt commented Jan 3, 2019

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues https://github.com/yiisoft/yii-core/issues/132

@samdark
Copy link
Member

samdark commented Jan 3, 2019

How about making it a single migration? We can do that since there were no package releases yet.

@Dzhuneyt
Copy link
Contributor Author

Dzhuneyt commented Jan 4, 2019

@samdark what about customers that upgrade from an older version of Yii? They will have the old migration already executed and the column type the wrong one.

@samdark
Copy link
Member

samdark commented Jan 4, 2019

There is no compatibility guarantee between Yii 2.0 and Yii 3.0. But if you think that two separate migrations are better, I'm fine with it.

@samdark samdark merged commit 00554d7 into yiisoft:master Jan 4, 2019
@samdark
Copy link
Member

samdark commented Jan 4, 2019

Merged. Thanks!

@Dzhuneyt Dzhuneyt deleted the 132-yii-core-Create_new_migration_for_change_level_column_in_logs_table branch January 4, 2019 15:14
@Dzhuneyt
Copy link
Contributor Author

Dzhuneyt commented Jan 4, 2019

There is no compatibility guarantee between Yii 2.0 and Yii 3.0. But if you think that two separate migrations are better, I'm fine with it.

I have bad experiencing changing old migrations' code for ANY reason in my day job. That's all :)

@Dzhuneyt
Copy link
Contributor Author

Dzhuneyt commented Jan 4, 2019 •
edited
Loading

@samdark just out of curiousity, now that a lot of functionalities have been moved outside of the yii-core project into their own dedicated projects - will they all have their own CHANGELOG file (I see this one doesn't, for example).

@samdark
Copy link
Member

samdark commented Jan 4, 2019

Yes. After first release.

devanych pushed a commit that referenced this pull request Dec 19, 2020
@Dzhuneyt @devanych
Changed the "level" column in "log" table to be integer again (#5)
10c2ead
devanych pushed a commit that referenced this pull request Dec 19, 2020
@Dzhuneyt @devanych
Changed the "level" column in "log" table to be integer again (#5)
d596465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dzhuneyt @samdark @hasMobi