Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Import tract docs #936

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Conversation

36000
Copy link
Collaborator

@36000 36000 commented Dec 9, 2022

Two things here:

  1. Update docs regarding name change to import_tract for importing custom tractographies
  2. Only run additional bundle recognition like endpoint filtering and orientation filtering if streamlines are found in the first place

@36000
Copy link
Collaborator Author

36000 commented Dec 9, 2022

@arokem this is ready for review / merge. All of the changes in AFQ/segmentation.py are because of indent after: if len(possible_fibers) > 0: (so not a lot has actually changed here)

@arokem
Copy link
Collaborator

arokem commented Dec 9, 2022

Does that if need an else clause? Raise a warning?

@36000
Copy link
Collaborator Author

36000 commented Dec 9, 2022

There is already this line:

self.logger.info(

@arokem
Copy link
Collaborator

arokem commented Dec 9, 2022

Oh! That works. I'll wait for the docbuild to finish and then merge this.

@arokem
Copy link
Collaborator

arokem commented Dec 9, 2022

OR still seems to be pretty finicky. But I think we should solve that elsewhere, so merging.

@arokem arokem merged commit 1b07cbb into yeatmanlab:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants