Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nightly tests #873

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Fix nightly tests #873

merged 2 commits into from
Aug 17, 2022

Conversation

36000
Copy link
Collaborator

@36000 36000 commented Aug 17, 2022 •
edited
Loading

SLR test is also revamped to be much faster (a few minutes or less)

@pep8speaks
Copy link

pep8speaks commented Aug 17, 2022 •
edited
Loading

Hello @36000! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-08-17 21:19:26 UTC

@arokem
Copy link
Collaborator

arokem commented Aug 17, 2022

Just making sure: this closes #753?

@36000
Copy link
Collaborator Author

36000 commented Aug 17, 2022

I think thats an old issue , this fixes #872 (and other broken nightly tests from the merge of #853 )

@arokem
Copy link
Collaborator

arokem commented Aug 17, 2022

Ha! Well, let's merge it and see what happens.

@arokem arokem merged commit f13b7df into yeatmanlab:master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@36000 @pep8speaks @arokem