[ENH] add anisotropic kurtosis, make dki default? #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DKI KFA (left) vs DKI FA (right) on HCP subejct |
|
@arokem this is ready for review / merge! |
arokem
reviewed
Feb 1, 2024
There was a problem hiding this comment.
Thanks for adding KFA! We might want to add a link to this paper somewhere in the documentation: https://www.ncbi.nlm.nih.gov/pmc/articles/PMC7028548/, which will help users understand how this differs from the DTI FA.
Regarding making DKI the default, I would be fine with that, but I'd suggest adding a check that the data can be used for DKI (i.e., that it has multiple non-zero b-values) before starting the run, and raising an informative error when that's not the case, telling users how they should change their call (i.e., where to change into "dti_fa" and "dti_md").
36000
force-pushed
the
anisotropic_kurtosis
branch
from
b8613d7
to
0674ee5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new anisotropic kurtosis parameter.
It also makes DKI tand fa/md/kfa/mk the default scalars for multishell data, and DTI FA/MD the default for single shell (our current default)