Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid removing empty message (#10167) #10233

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Avoid removing empty message (#10167) #10233

merged 1 commit into from
Oct 9, 2024

Conversation

FloatingCrowbar
Copy link
Collaborator

No description provided.

@FloatingCrowbar FloatingCrowbar requested a review from a team as a code owner October 8, 2024 21:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024 •
edited
Loading

⚪ 2024-10-08 21:18:53 UTC Pre-commit check for 7520303 has started.
⚪ 2024-10-08 21:21:26 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-10-08 21:27:46 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024 •
edited
Loading

⚪ 2024-10-08 21:19:04 UTC Pre-commit check for 7520303 has started.
⚪ 2024-10-08 21:21:44 UTC Build linux-x86_64-release-asan is running...
🟢 2024-10-08 21:44:42 UTC Build successful.
⚪ 2024-10-08 21:44:57 UTC Tests are running...
🔴 2024-10-08 23:49:15 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10020 9938 0 10 26 46

🟢 2024-10-08 23:49:59 UTC ydbd size 5.5 GiB changed* by -41.9 KiB, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 1143523 merge: 7520303 diff diff %
ydbd size 5 955 071 360 Bytes 5 955 028 408 Bytes -41.9 KiB -0.001%
ydbd stripped size 1 493 427 296 Bytes 1 493 420 192 Bytes -6.9 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024 •
edited
Loading

⚪ 2024-10-08 21:20:02 UTC Pre-commit check for 7520303 has started.
⚪ 2024-10-08 21:23:05 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-10-08 22:02:53 UTC Build successful.
⚪ 2024-10-08 22:03:10 UTC Tests are running...
🔴 2024-10-08 23:33:39 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14160 12812 0 5 1301 42

🟢 2024-10-08 23:34:17 UTC ydbd size 8.2 GiB changed* by -57.6 KiB, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 1143523 merge: 7520303 diff diff %
ydbd size 8 807 998 112 Bytes 8 807 939 176 Bytes -57.6 KiB -0.001%
ydbd stripped size 480 033 032 Bytes 480 028 744 Bytes -4.2 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@FloatingCrowbar FloatingCrowbar merged commit 9764825 into ydb-platform:stable-24-3 Oct 9, 2024
8 of 12 checks passed
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Oct 14, 2024
@FloatingCrowbar @uzhastik
Avoid removing empty message (ydb-platform#10167) (ydb-platform#10233)
e3133f8
This was referenced Oct 29, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fomichev3000 fomichev3000 fomichev3000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FloatingCrowbar @fomichev3000