Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid removing empty message #10167

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Avoid removing empty message #10167

merged 1 commit into from
Oct 7, 2024

Conversation

FloatingCrowbar
Copy link
Collaborator

No description provided.

@FloatingCrowbar FloatingCrowbar requested a review from a team as a code owner October 7, 2024 12:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024 •
edited
Loading

⚪ 2024-10-07 12:56:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0676eae has started.
⚪ 2024-10-07 12:56:30 UTC Artifacts will be uploaded here
⚪ 2024-10-07 12:59:18 UTC ya make is running...
⚫ 2024-10-07 13:51:23 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024 •
edited
Loading

⚪ 2024-10-07 12:56:42 UTC Pre-commit check linux-x86_64-release-asan for 0676eae has started.
⚪ 2024-10-07 12:56:53 UTC Artifacts will be uploaded here
⚪ 2024-10-07 12:59:44 UTC ya make is running...
⚫ 2024-10-07 13:51:24 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024 •
edited
Loading

⚪ 2024-10-07 13:56:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1c102f7 has started.
⚪ 2024-10-07 13:56:59 UTC Artifacts will be uploaded here
⚪ 2024-10-07 13:59:48 UTC ya make is running...
⚫ 2024-10-07 14:01:02 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024 •
edited
Loading

⚪ 2024-10-07 13:57:15 UTC Pre-commit check linux-x86_64-release-asan for 1c102f7 has started.
⚪ 2024-10-07 13:57:26 UTC Artifacts will be uploaded here
⚪ 2024-10-07 14:00:23 UTC ya make is running...
⚫ 2024-10-07 14:01:01 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024 •
edited
Loading

⚪ 2024-10-07 14:03:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for 443d6b9 has started.
⚪ 2024-10-07 14:04:11 UTC Artifacts will be uploaded here
⚪ 2024-10-07 14:09:17 UTC ya make is running...
🟡 2024-10-07 14:57:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15036 13555 0 4 1377 100

⚪ 2024-10-07 14:58:34 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-07 15:10:15 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
101 (only retried tests) 9 0 0 1 91

🟢 2024-10-07 15:10:22 UTC Build successful.
🟢 2024-10-07 15:10:42 UTC ydbd size 2.8 GiB changed* by -39.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 13d88b2 merge: 443d6b9 diff diff %
ydbd size 3 008 222 200 Bytes 3 008 182 296 Bytes -39.0 KiB -0.001%
ydbd stripped size 477 354 328 Bytes 477 345 368 Bytes -8.8 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024 •
edited
Loading

⚪ 2024-10-07 14:04:51 UTC Pre-commit check linux-x86_64-release-asan for 443d6b9 has started.
⚪ 2024-10-07 14:05:03 UTC Artifacts will be uploaded here
⚪ 2024-10-07 14:07:55 UTC ya make is running...
🟡 2024-10-07 15:30:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10269 10065 0 52 52 100

🟢 2024-10-07 15:31:28 UTC Build successful.
🟢 2024-10-07 15:32:01 UTC ydbd size 5.7 GiB changed* by -30.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 13d88b2 merge: 443d6b9 diff diff %
ydbd size 6 096 449 544 Bytes 6 096 418 784 Bytes -30.0 KiB -0.001%
ydbd stripped size 1 520 159 568 Bytes 1 520 158 224 Bytes -1.3 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@FloatingCrowbar FloatingCrowbar merged commit 7f014fa into ydb-platform:main Oct 7, 2024
10 checks passed
@GrigoriyPA GrigoriyPA mentioned this pull request Oct 8, 2024
Merged
FloatingCrowbar added a commit to FloatingCrowbar/ydb that referenced this pull request Oct 8, 2024
@FloatingCrowbar
Avoid removing empty message (ydb-platform#10167)
02ed0b5
FloatingCrowbar added a commit that referenced this pull request Oct 9, 2024
@FloatingCrowbar
Avoid removing empty message (#10167) (#10233)
9764825
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexnick88 alexnick88 alexnick88 approved these changes

@nshestakov nshestakov Awaiting requested review from nshestakov nshestakov is a code owner automatically assigned from ydb-platform/topics

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FloatingCrowbar @alexnick88