Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix allocation cleaning race from separated thread after scope cleani… #10096

Merged
merged 2 commits into from
Oct 5, 2024
Merged

fix allocation cleaning race from separated thread after scope cleani… #10096

merged 2 commits into from
Oct 5, 2024

Conversation

ivanmorozov333
Copy link
Collaborator

…ng and reallocate on scan reask

  • Improvement
  • Bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024 •
edited
Loading

⚪ 2024-10-04 12:30:31 UTC Pre-commit check linux-x86_64-release-asan for 6855be3 has started.
⚪ 2024-10-04 12:30:41 UTC Artifacts will be uploaded here
⚪ 2024-10-04 12:33:30 UTC ya make is running...
🟡 2024-10-04 14:04:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11550 11006 0 349 65 130

🟢 2024-10-04 14:05:11 UTC Build successful.
🟡 2024-10-04 14:05:44 UTC ydbd size 5.7 GiB changed* by 337.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ce8c6eb merge: 6855be3 diff diff %
ydbd size 6 082 132 296 Bytes 6 082 477 952 Bytes 337.6 KiB 0.006%
ydbd stripped size 1 519 808 368 Bytes 1 519 846 512 Bytes 37.2 KiB 0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024 •
edited
Loading

⚪ 2024-10-04 12:30:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6855be3 has started.
⚪ 2024-10-04 12:30:53 UTC Artifacts will be uploaded here
⚪ 2024-10-04 12:33:45 UTC ya make is running...
🟡 2024-10-04 13:22:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16493 14727 0 275 1376 115

⚪ 2024-10-04 13:23:52 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-04 13:32:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
388 (only retried tests) 6 0 272 0 110

⚪ 2024-10-04 13:32:13 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-10-04 13:40:43 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
382 (only retried tests) 2 0 271 0 109

🟢 2024-10-04 13:40:52 UTC Build successful.
🟡 2024-10-04 13:41:17 UTC ydbd size 2.8 GiB changed* by 144.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ce8c6eb merge: 6855be3 diff diff %
ydbd size 3 001 253 376 Bytes 3 001 401 736 Bytes 144.9 KiB 0.005%
ydbd stripped size 477 265 272 Bytes 477 279 224 Bytes 13.6 KiB 0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 5, 2024 •
edited
Loading

⚪ 2024-10-05 06:36:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for e34416d has started.
⚪ 2024-10-05 06:36:48 UTC Artifacts will be uploaded here
⚪ 2024-10-05 06:39:37 UTC ya make is running...
🟡 2024-10-05 07:29:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16492 15002 0 8 1380 102

⚪ 2024-10-05 07:31:20 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-05 07:45:17 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
107 (only retried tests) 13 0 0 0 94

🟢 2024-10-05 07:45:24 UTC Build successful.
🟡 2024-10-05 07:45:43 UTC ydbd size 2.8 GiB changed* by 142.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: d7773b7 merge: e34416d diff diff %
ydbd size 3 002 131 272 Bytes 3 002 277 360 Bytes 142.7 KiB 0.005%
ydbd stripped size 477 408 120 Bytes 477 418 296 Bytes 9.9 KiB 0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 5, 2024 •
edited
Loading

⚪ 2024-10-05 06:37:03 UTC Pre-commit check linux-x86_64-release-asan for e34416d has started.
⚪ 2024-10-05 06:37:14 UTC Artifacts will be uploaded here
⚪ 2024-10-05 06:40:16 UTC ya make is running...
🟡 2024-10-05 08:16:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11551 11248 0 109 79 115

🟢 2024-10-05 08:17:31 UTC Build successful.
🟡 2024-10-05 08:18:04 UTC ydbd size 5.7 GiB changed* by 348.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: d7773b7 merge: e34416d diff diff %
ydbd size 6 084 074 496 Bytes 6 084 431 512 Bytes 348.6 KiB 0.006%
ydbd stripped size 1 520 356 528 Bytes 1 520 400 176 Bytes 42.6 KiB 0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review October 5, 2024 10:05
@ivanmorozov333 ivanmorozov333 merged commit 66e070c into ydb-platform:main Oct 5, 2024
10 checks passed
@ivanmorozov333 ivanmorozov333 deleted the race_on_scope_cleaning branch October 5, 2024 10:52
@zverevgeny zverevgeny linked an issue Oct 5, 2024 that may be closed by this pull request
CS fails on VERIFY in NGroupedMemoryManager::TManager::UnregisterGroup #9607
Open
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Oct 7, 2024
@ivanmorozov333 @zverevgeny
fix allocation cleaning race from separated thread after scope cleani… (
9b28dc3 
ydb-platform#10096)
@GrigoriyPA GrigoriyPA mentioned this pull request Oct 8, 2024
Merged
This was referenced Oct 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zverevgeny zverevgeny zverevgeny approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CS fails on VERIFY in NGroupedMemoryManager::TManager::UnregisterGroup
2 participants
@ivanmorozov333 @zverevgeny