fix: unnecessary exception throw

yajra · Nov 15, 2023 · 9ce95f4 · 9ce95f4
1 parent 979ac47
commit 9ce95f4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 19 deletions.
diff --git a/src/Contracts/DataTableHtmlBuilder.php b/src/Contracts/DataTableHtmlBuilder.php
@@ -8,8 +8,6 @@ interface DataTableHtmlBuilder
      * Handle building of dataTables html.
      *
      * @return \Yajra\DataTables\Html\Builder
-     *
-     * @throws \Exception
      */
     public function handle();
 }
diff --git a/src/Html/DataTableHtml.php b/src/Html/DataTableHtml.php
@@ -10,29 +10,24 @@
  */
 abstract class DataTableHtml implements DataTableHtmlBuilder
 {
-    /**
-     * @var \Yajra\DataTables\Html\Builder|null
-     */
     protected ?Builder $htmlBuilder = null;
 
-    /**
-     * @return \Yajra\DataTables\Html\Builder
-     *
-     * @throws \Exception
-     */
     public static function make(): Builder
     {
         if (func_get_args()) {
             return (new static(...func_get_args()))->handle();
         }
 
-        return app(static::class)->handle();
+        /** @var static $html */
+        $html = app(static::class);
+
+        return $html->handle();
     }
 
     /**
      * @param  string  $method
      * @param  mixed  $parameters
-     * @return mixed
+     * @return \Yajra\DataTables\Html\Builder
      *
      * @throws \Exception
      */
@@ -45,9 +40,6 @@ public function __call(string $method, $parameters)
         throw new BadMethodCallException("Method {$method} does not exists");
     }
 
-    /**
-     * @return \Yajra\DataTables\Html\Builder
-     */
     protected function getHtmlBuilder(): Builder
     {
         if ($this->htmlBuilder) {
@@ -57,10 +49,6 @@ protected function getHtmlBuilder(): Builder
         return $this->htmlBuilder = app(Builder::class);
     }
 
-    /**
-     * @param  \Yajra\DataTables\Html\Builder  $builder
-     * @return static
-     */
     public function setHtmlBuilder(Builder $builder): static
     {
         $this->htmlBuilder = $builder;