Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Puma 6.0 #25

Merged
merged 5 commits into from
Oct 21, 2022
Merged

Support for Puma 6.0 #25

merged 5 commits into from
Oct 21, 2022

Conversation

ollym
Copy link
Contributor

@ollym ollym commented Oct 17, 2022

Puma 6 introduced some small breaking changes to the Puma::Server API, seemed easier to handle these without pattern matching the puma version string.

@ollym
Copy link
Contributor Author

ollym commented Oct 17, 2022

Hey @Envek let me know if this works or if you'd like a different direction

Envek
Envek requested changes Oct 18, 2022
View reviewed changes
Copy link
Member

@Envek Envek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the pull request!

In general it should work, yes. However, I wonder, whether it worth the effort to support all Puma version at once. We can just stick with Puma 6 only, I think. Users of older Puma versions always can use older yabeda-puma-plugin versions.

lib/puma/plugin/yabeda_prometheus.rb Show resolved Hide resolved
@ollym
Copy link
Contributor Author

ollym commented Oct 18, 2022

@Envek I'll update the code to only work for Puma 6

@Envek
Copy link
Member

Envek commented Oct 19, 2022 •
edited
Loading

Hm, no idea what is wrong with specs…

Most probably some dependencies broke tests, because even current master started to fail with that Errno::EAGAIN: Resource temporarily unavailable error…

@Envek
Copy link
Member

Envek commented Oct 21, 2022

@skryukov, thanks a lot!

@Envek Envek merged commit 8bfca3c into yabeda-rb:master Oct 21, 2022
@ollym
Copy link
Contributor Author

ollym commented Oct 21, 2022

@Envek thanks for merging, think we could get a new gem cut too? Thanks

Envek added a commit that referenced this pull request Oct 21, 2022
@Envek
Merge remote-tracking branch 'origin/master' into phased-restart
c7fe441 
* origin/master:
  Support for Puma 6.0 (#25)
  Test against different versions of Puma and newer version of Ruby
  CI: Update Action versions, quote "3.0" (#24)
Envek added a commit that referenced this pull request Oct 21, 2022
@Envek
Merge remote-tracking branch 'origin/master' into phased-restart
8806588 
* origin/master:
  Support for Puma 6.0 (#25)
  Test against different versions of Puma and newer version of Ruby
  CI: Update Action versions, quote "3.0" (#24)
@Envek
Copy link
Member

Envek commented Oct 24, 2022

Thank you for the pull request! Released in 0.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Envek Envek Envek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ollym @Envek @skryukov