Fix dynamic callback method detection #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delawski
requested changes
Jul 22, 2024
There was a problem hiding this comment.
@shadyvb Thanks for that fix 🙌
I've changed the target branch to develop since we'd like to release this update as part of the upcoming 4.0.1 release. All of my comments are just about that. I'll try to address them myself, directly in GitHub, so that we're clear right away.
delawski
approved these changes
Jul 22, 2024
delawski
reviewed
Jul 22, 2024
|
The Lint and Test task succeeded so I'm merging the PR to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1468.
Fixed the dynamic callback locating routine by removing the hyphen as a valid function name character.
Checklist
contributing.md).Release Changelog
Release Checklist
masterbranch.readme.txt.stream.php.Stable taginreadme.txt.classes/class-plugin.php.