254 unit tests for hotregion #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently in Python 3.8 and 3.9 it fails due to a | used as "or" in isinstance()... |
DevarshiChoudhury
requested changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I added basic run, getter and setter tests for all functions in hotregion.py
However, not every reasonable model configuration has been tested. For example, I am not testing ceding and omitting hot spots and numerical atmospheres yet. Best would be to also add some asserts to ensure that the correct values come out. Still, the tests we have so far can be checked and merged in my opinion.
Here I also deprecate the
is_secondarykeyword argument in the HotRegion class. So if this issue is closed that other issue can also be closed.