What is this PR for?

This PR fixes #242.

What was the source of the problem?

When moveToViewController(at: Int, animated: Bool) or moveTo(viewController: UIViewController, animated: Bool) was called, user interaction was disabled to prevent the user from interacting with the UI in the middle of a transition. Then, in scrollViewDidEndScrollingAnimation(_:UIScrollView), user interaction would be enabled again. However, when passing false for theanimated parameter, this method does not get called and user interaction won't be enabled again.

What's the fix for the problem?

The fix is simple. We don't need to disable user interaction when the transition is not animated since the contentOffset of the scroll view gets set immediately. I tested it and can I can confirm that it works now.

How to test these changes

In the corresponding issue, you will find a link to an example project which demonstrates the issue. Run it and tap the bar button item to confirm the issue. Then open the Cartfile and specify this branch:

github "raphaklr/XLPagerTabStrip" "fix/user_interaction_disabled_when_not_animating"

Run

carthage update --platform ios

, build the project and see the issue fixed.

@mtnbarreto @mats-claassen please review and merge 🙂