Fix: Inconsistencies when using SwipeAction #1504
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
On iOS 10 and lower, when adding a trailing
SwipeAction
to aRow
, this action is cast to aUITableViewRowAction
and returned fromtableView(_:editActionsForRowAt:)
inFormViewController
. Unfortunately the same does not happen on iOS 11, since there aSwipeAction
is cast toUIContextualAction
instead ofUITableViewRowAction
, leavingtableView(_:editActionsForRowAt:)
to return nothing and making UIKit fall back to default behavior.This leads to inconsistent behavior between iOS versions, which is, of course, unfavorable.
Solution:
I propose the introduction of
tableViewRowAction(forRow:)
alongside the already existingfunc contextualAction(forRow:)
. This way, intableView(_:editActionsForRowAt:)
, we can explicitly requestUITableViewRowActions
and establish consistent behavior across iOS versions.Demo:
Given the following form setup…
… the current behavior when tapping the delete icon on iOS 11 is as follows:
The expected behavior, however, is the same as it already is on iOS 10 and lower: